Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
f214c95778 | ||
|
|
910a16a998 |
@@ -1,119 +1,89 @@
|
||||
"""Append-only, tamper-evident audit chain for AIOS V2R1."""
|
||||
"""Append-only audit chain for AIOS V2R1."""
|
||||
from __future__ import annotations
|
||||
|
||||
from collections.abc import Callable
|
||||
from contextlib import closing
|
||||
import hashlib
|
||||
import json
|
||||
import os
|
||||
from pathlib import Path
|
||||
import sqlite3
|
||||
from typing import Any, TypeVar
|
||||
from typing import Any
|
||||
|
||||
from .tenant_context import ConflictError, canonical_json, isoformat, require_ident
|
||||
|
||||
T = TypeVar("T")
|
||||
from .tenant_context import canonical_json, isoformat, require_ident
|
||||
|
||||
|
||||
class AuditLog:
|
||||
def __init__(self, database: str | Path) -> None:
|
||||
self.database = Path(database)
|
||||
self.database.parent.mkdir(parents=True, exist_ok=True)
|
||||
self._initialize()
|
||||
os.chmod(self.database, 0o600)
|
||||
|
||||
def _connect(self) -> sqlite3.Connection:
|
||||
db = sqlite3.connect(str(self.database), timeout=30)
|
||||
db.execute("PRAGMA journal_mode=WAL")
|
||||
db.execute("PRAGMA synchronous=FULL")
|
||||
db.execute("PRAGMA busy_timeout=30000")
|
||||
return db
|
||||
|
||||
def _storage(self, operation: Callable[[], T]) -> T:
|
||||
failure: ConflictError | None = None
|
||||
try:
|
||||
return operation()
|
||||
except sqlite3.Error:
|
||||
failure = ConflictError("audit storage unavailable")
|
||||
raise failure
|
||||
|
||||
def _initialize(self) -> None:
|
||||
def initialize() -> None:
|
||||
with closing(self._connect()) as connection, connection as db:
|
||||
db.execute(
|
||||
"""
|
||||
CREATE TABLE IF NOT EXISTS audit_events (
|
||||
seq INTEGER PRIMARY KEY AUTOINCREMENT,
|
||||
tenant_id TEXT NOT NULL,
|
||||
trace_id TEXT NOT NULL,
|
||||
event_type TEXT NOT NULL,
|
||||
payload TEXT NOT NULL,
|
||||
previous_hash TEXT NOT NULL,
|
||||
event_hash TEXT NOT NULL UNIQUE,
|
||||
created_at TEXT NOT NULL
|
||||
)
|
||||
"""
|
||||
self.database = str(database)
|
||||
with sqlite3.connect(self.database) as db:
|
||||
db.execute("PRAGMA journal_mode=WAL")
|
||||
db.execute(
|
||||
"""
|
||||
CREATE TABLE IF NOT EXISTS audit_events (
|
||||
seq INTEGER PRIMARY KEY AUTOINCREMENT,
|
||||
tenant_id TEXT NOT NULL,
|
||||
trace_id TEXT NOT NULL,
|
||||
event_type TEXT NOT NULL,
|
||||
payload TEXT NOT NULL,
|
||||
previous_hash TEXT NOT NULL,
|
||||
event_hash TEXT NOT NULL UNIQUE,
|
||||
created_at TEXT NOT NULL
|
||||
)
|
||||
self._storage(initialize)
|
||||
"""
|
||||
)
|
||||
|
||||
def append(
|
||||
self, *, tenant_id: str, trace_id: str, event_type: str,
|
||||
payload: dict[str, Any],
|
||||
) -> str:
|
||||
def append(self, *, tenant_id: str, trace_id: str, event_type: str, payload: dict[str, Any]) -> str:
|
||||
tenant_id = require_ident("tenant_id", tenant_id, tenant=True)
|
||||
trace_id = require_ident("trace_id", trace_id)
|
||||
event_type = require_ident("event_type", event_type)
|
||||
|
||||
def write() -> str:
|
||||
with closing(self._connect()) as connection, connection as db:
|
||||
db.execute("BEGIN IMMEDIATE")
|
||||
previous = db.execute(
|
||||
"SELECT event_hash FROM audit_events ORDER BY seq DESC LIMIT 1"
|
||||
).fetchone()
|
||||
previous_hash = previous[0] if previous else "GENESIS"
|
||||
body = {
|
||||
"tenant_id": tenant_id, "trace_id": trace_id,
|
||||
"event_type": event_type, "payload": payload,
|
||||
"previous_hash": previous_hash, "created_at": isoformat(),
|
||||
}
|
||||
digest = hashlib.sha256(canonical_json(body)).hexdigest()
|
||||
db.execute(
|
||||
"INSERT INTO audit_events VALUES(NULL,?,?,?,?,?,?,?)",
|
||||
(
|
||||
tenant_id, trace_id, event_type,
|
||||
json.dumps(payload, ensure_ascii=False),
|
||||
previous_hash, digest, body["created_at"],
|
||||
),
|
||||
)
|
||||
db.commit()
|
||||
return digest
|
||||
|
||||
return self._storage(write)
|
||||
with sqlite3.connect(self.database) as db:
|
||||
previous = db.execute(
|
||||
"SELECT event_hash FROM audit_events ORDER BY seq DESC LIMIT 1"
|
||||
).fetchone()
|
||||
previous_hash = previous[0] if previous else "GENESIS"
|
||||
body = {
|
||||
"tenant_id": tenant_id,
|
||||
"trace_id": trace_id,
|
||||
"event_type": event_type,
|
||||
"payload": payload,
|
||||
"previous_hash": previous_hash,
|
||||
"created_at": isoformat(),
|
||||
}
|
||||
digest = hashlib.sha256(
|
||||
canonical_json(body)
|
||||
).hexdigest()
|
||||
db.execute(
|
||||
"INSERT INTO audit_events VALUES(NULL,?,?,?,?,?,?,?)",
|
||||
(
|
||||
tenant_id,
|
||||
trace_id,
|
||||
event_type,
|
||||
json.dumps(payload, ensure_ascii=False),
|
||||
previous_hash,
|
||||
digest,
|
||||
body["created_at"],
|
||||
),
|
||||
)
|
||||
return digest
|
||||
|
||||
def verify(self) -> bool:
|
||||
def check() -> bool:
|
||||
previous = "GENESIS"
|
||||
with closing(self._connect()) as connection, connection as db:
|
||||
rows = db.execute(
|
||||
"SELECT tenant_id,trace_id,event_type,payload,previous_hash,"
|
||||
"event_hash,created_at FROM audit_events ORDER BY seq"
|
||||
)
|
||||
for row in rows:
|
||||
try:
|
||||
payload = json.loads(row[3])
|
||||
except (json.JSONDecodeError, TypeError):
|
||||
return False
|
||||
body = {
|
||||
"tenant_id": row[0], "trace_id": row[1],
|
||||
"event_type": row[2], "payload": payload,
|
||||
"previous_hash": row[4], "created_at": row[6],
|
||||
}
|
||||
if row[4] != previous:
|
||||
return False
|
||||
digest = hashlib.sha256(canonical_json(body)).hexdigest()
|
||||
if digest != row[5]:
|
||||
return False
|
||||
previous = digest
|
||||
return True
|
||||
|
||||
return self._storage(check)
|
||||
previous = "GENESIS"
|
||||
with sqlite3.connect(self.database) as db:
|
||||
rows = db.execute(
|
||||
"SELECT tenant_id,trace_id,event_type,payload,previous_hash,event_hash,created_at "
|
||||
"FROM audit_events ORDER BY seq"
|
||||
)
|
||||
for row in rows:
|
||||
body = {
|
||||
"tenant_id": row[0],
|
||||
"trace_id": row[1],
|
||||
"event_type": row[2],
|
||||
"payload": json.loads(row[3]),
|
||||
"previous_hash": row[4],
|
||||
"created_at": row[6],
|
||||
}
|
||||
if row[4] != previous:
|
||||
return False
|
||||
digest = hashlib.sha256(canonical_json(body)).hexdigest()
|
||||
if digest != row[5]:
|
||||
return False
|
||||
previous = digest
|
||||
return True
|
||||
|
||||
@@ -1,37 +1,13 @@
|
||||
"""AIOS V2R1 Tenant Cell lifecycle and atomic registry primitives."""
|
||||
"""AIOS V2R1 Tenant Cell lifecycle CLI primitives."""
|
||||
from __future__ import annotations
|
||||
|
||||
from contextlib import contextmanager
|
||||
from dataclasses import dataclass
|
||||
from datetime import datetime, timezone
|
||||
import fcntl
|
||||
import json
|
||||
import os
|
||||
from pathlib import Path
|
||||
import tempfile
|
||||
import threading
|
||||
from typing import Iterator
|
||||
|
||||
from .tenant_context import ValidationError, require_ident
|
||||
|
||||
_THREAD_LOCKS_GUARD = threading.Lock()
|
||||
_THREAD_LOCKS: dict[str, threading.RLock] = {}
|
||||
_STATES = {"created", "starting", "healthy", "upgrading", "rollback", "failed"}
|
||||
_TRANSITIONS = {
|
||||
"created": {"starting", "failed"},
|
||||
"starting": {"healthy", "failed"},
|
||||
"healthy": {"upgrading", "failed"},
|
||||
"upgrading": {"healthy", "rollback", "failed"},
|
||||
"rollback": {"healthy", "failed"},
|
||||
"failed": {"starting"},
|
||||
}
|
||||
|
||||
|
||||
def _lock_for(path: Path) -> threading.RLock:
|
||||
key = str(path.resolve())
|
||||
with _THREAD_LOCKS_GUARD:
|
||||
return _THREAD_LOCKS.setdefault(key, threading.RLock())
|
||||
|
||||
|
||||
@dataclass(frozen=True)
|
||||
class CellRecord:
|
||||
@@ -47,116 +23,51 @@ class CellManager:
|
||||
def __init__(self, registry: str | Path) -> None:
|
||||
self.registry = Path(registry)
|
||||
self.registry.parent.mkdir(parents=True, exist_ok=True)
|
||||
self._lock_file = self.registry.with_name(self.registry.name + ".lock")
|
||||
self._thread_lock = _lock_for(self.registry)
|
||||
with self._exclusive():
|
||||
if not self.registry.exists():
|
||||
self._save({"cells": {}})
|
||||
else:
|
||||
self._load()
|
||||
if not self.registry.exists():
|
||||
self.registry.write_text("{\"cells\":{}}\n", encoding="utf-8")
|
||||
|
||||
@contextmanager
|
||||
def _exclusive(self) -> Iterator[None]:
|
||||
with self._thread_lock:
|
||||
with self._lock_file.open("a+", encoding="utf-8") as lock:
|
||||
os.chmod(self._lock_file, 0o600)
|
||||
fcntl.flock(lock.fileno(), fcntl.LOCK_EX)
|
||||
try:
|
||||
yield
|
||||
finally:
|
||||
fcntl.flock(lock.fileno(), fcntl.LOCK_UN)
|
||||
def _load(self) -> dict:
|
||||
return json.loads(self.registry.read_text(encoding="utf-8"))
|
||||
|
||||
def _load(self) -> dict[str, dict[str, dict[str, str]]]:
|
||||
failure: ValidationError | None = None
|
||||
try:
|
||||
value = json.loads(self.registry.read_text(encoding="utf-8"))
|
||||
except (OSError, UnicodeError, json.JSONDecodeError):
|
||||
failure = ValidationError("cell registry unavailable")
|
||||
if failure is not None:
|
||||
raise failure
|
||||
if not isinstance(value, dict) or set(value) != {"cells"}:
|
||||
raise ValidationError("cell registry unavailable")
|
||||
cells = value["cells"]
|
||||
if not isinstance(cells, dict):
|
||||
raise ValidationError("cell registry unavailable")
|
||||
expected = {
|
||||
"tenant_id", "cell_id", "version", "state",
|
||||
"config_digest", "created_at",
|
||||
}
|
||||
for tenant_id, item in cells.items():
|
||||
if (
|
||||
not isinstance(item, dict) or set(item) != expected
|
||||
or item.get("tenant_id") != tenant_id
|
||||
or item.get("state") not in _STATES
|
||||
or any(not isinstance(item.get(name), str) for name in expected)
|
||||
):
|
||||
raise ValidationError("cell registry unavailable")
|
||||
return value
|
||||
|
||||
def _save(self, value: dict[str, object]) -> None:
|
||||
descriptor, temporary_name = tempfile.mkstemp(
|
||||
prefix=f".{self.registry.name}.", dir=self.registry.parent, text=True
|
||||
def _save(self, value: dict) -> None:
|
||||
self.registry.write_text(
|
||||
json.dumps(value, ensure_ascii=False, indent=2) + "\n",
|
||||
encoding="utf-8",
|
||||
)
|
||||
temporary = Path(temporary_name)
|
||||
try:
|
||||
with os.fdopen(descriptor, "w", encoding="utf-8") as output:
|
||||
json.dump(value, output, ensure_ascii=False, indent=2)
|
||||
output.write("\n")
|
||||
output.flush()
|
||||
os.fsync(output.fileno())
|
||||
os.chmod(temporary, 0o600)
|
||||
os.replace(temporary, self.registry)
|
||||
directory = os.open(self.registry.parent, os.O_RDONLY | os.O_DIRECTORY)
|
||||
try:
|
||||
os.fsync(directory)
|
||||
finally:
|
||||
os.close(directory)
|
||||
finally:
|
||||
if temporary.exists():
|
||||
temporary.unlink()
|
||||
|
||||
def create(
|
||||
self, tenant_id: str, cell_id: str, version: str, digest: str,
|
||||
) -> CellRecord:
|
||||
def create(self, tenant_id: str, cell_id: str, version: str, digest: str) -> CellRecord:
|
||||
tenant_id = require_ident("tenant_id", tenant_id, tenant=True)
|
||||
cell_id = require_ident("cell_id", cell_id)
|
||||
version = require_ident("version", version)
|
||||
digest = require_ident("digest", digest)
|
||||
with self._exclusive():
|
||||
data = self._load()
|
||||
if tenant_id in data["cells"]:
|
||||
raise ValidationError("tenant already has a cell")
|
||||
record = CellRecord(
|
||||
tenant_id, cell_id, version, "created", digest,
|
||||
datetime.now(timezone.utc).isoformat(),
|
||||
)
|
||||
data["cells"][tenant_id] = record.__dict__
|
||||
self._save(data)
|
||||
return record
|
||||
data = self._load()
|
||||
if tenant_id in data["cells"]:
|
||||
raise ValidationError("tenant already has a cell")
|
||||
record = CellRecord(
|
||||
tenant_id,
|
||||
cell_id,
|
||||
version,
|
||||
"created",
|
||||
digest,
|
||||
datetime.now(timezone.utc).isoformat(),
|
||||
)
|
||||
data["cells"][tenant_id] = record.__dict__
|
||||
self._save(data)
|
||||
return record
|
||||
|
||||
def status(self, tenant_id: str) -> CellRecord:
|
||||
tenant_id = require_ident("tenant_id", tenant_id, tenant=True)
|
||||
with self._exclusive():
|
||||
data = self._load()
|
||||
item = data["cells"].get(tenant_id)
|
||||
if not item:
|
||||
raise ValidationError("unknown tenant")
|
||||
return CellRecord(**item)
|
||||
data = self._load()
|
||||
item = data["cells"].get(tenant_id)
|
||||
if not item:
|
||||
raise ValidationError("unknown tenant")
|
||||
return CellRecord(**item)
|
||||
|
||||
def transition(self, tenant_id: str, state: str) -> CellRecord:
|
||||
tenant_id = require_ident("tenant_id", tenant_id, tenant=True)
|
||||
if state not in _STATES:
|
||||
allowed = {"created", "starting", "healthy", "upgrading", "rollback", "failed"}
|
||||
if state not in allowed:
|
||||
raise ValidationError("invalid cell state")
|
||||
with self._exclusive():
|
||||
data = self._load()
|
||||
item = data["cells"].get(tenant_id)
|
||||
if not item:
|
||||
raise ValidationError("unknown tenant")
|
||||
current = item["state"]
|
||||
if state == current:
|
||||
return CellRecord(**item)
|
||||
if state not in _TRANSITIONS[current]:
|
||||
raise ValidationError(f"invalid cell transition: {current}->{state}")
|
||||
item["state"] = state
|
||||
self._save(data)
|
||||
return CellRecord(**item)
|
||||
data = self._load()
|
||||
item = data["cells"].get(tenant_id)
|
||||
if not item:
|
||||
raise ValidationError("unknown tenant")
|
||||
item["state"] = state
|
||||
self._save(data)
|
||||
return CellRecord(**item)
|
||||
|
||||
@@ -7,7 +7,6 @@ import sys
|
||||
|
||||
from .cell_manager import CellManager
|
||||
from .ingress_service import serve
|
||||
from .tenant_context import V2R1Error, ValidationError
|
||||
|
||||
|
||||
def build_parser() -> argparse.ArgumentParser:
|
||||
@@ -27,6 +26,7 @@ def build_parser() -> argparse.ArgumentParser:
|
||||
transition = sub.add_parser("transition")
|
||||
transition.add_argument("tenant_id")
|
||||
transition.add_argument("state")
|
||||
|
||||
return parser
|
||||
|
||||
|
||||
@@ -37,42 +37,27 @@ def build_serve_parser() -> argparse.ArgumentParser:
|
||||
return parser
|
||||
|
||||
|
||||
def _domain_failure(error: V2R1Error) -> int:
|
||||
code = "VALIDATION_ERROR" if isinstance(error, ValidationError) else "RUNTIME_ERROR"
|
||||
print(
|
||||
json.dumps({"code": code, "error": str(error)}, ensure_ascii=False, sort_keys=True),
|
||||
file=sys.stderr,
|
||||
)
|
||||
return 3
|
||||
|
||||
|
||||
def main(argv: list[str] | None = None) -> int:
|
||||
values = list(sys.argv[1:] if argv is None else argv)
|
||||
service_mode = (
|
||||
bool(values) and values[0] == "serve"
|
||||
bool(values)
|
||||
and values[0] == "serve"
|
||||
and (len(values) == 1 or values[1].startswith("-"))
|
||||
)
|
||||
if service_mode:
|
||||
serve_args = build_serve_parser().parse_args(values[1:])
|
||||
serve(serve_args.host, serve_args.port)
|
||||
return 0
|
||||
|
||||
args = build_parser().parse_args(values)
|
||||
try:
|
||||
manager = CellManager(args.registry)
|
||||
if args.command == "create":
|
||||
result = manager.create(
|
||||
args.tenant_id, args.cell_id, args.version, args.digest
|
||||
)
|
||||
elif args.command == "status":
|
||||
result = manager.status(args.tenant_id)
|
||||
elif args.command == "transition":
|
||||
result = manager.transition(args.tenant_id, args.state)
|
||||
else:
|
||||
return 2
|
||||
except V2R1Error as error:
|
||||
return _domain_failure(error)
|
||||
|
||||
manager = CellManager(args.registry)
|
||||
if args.command == "create":
|
||||
result = manager.create(args.tenant_id, args.cell_id, args.version, args.digest)
|
||||
elif args.command == "status":
|
||||
result = manager.status(args.tenant_id)
|
||||
elif args.command == "transition":
|
||||
result = manager.transition(args.tenant_id, args.state)
|
||||
else:
|
||||
return 2
|
||||
print(json.dumps(result.__dict__, ensure_ascii=False, sort_keys=True))
|
||||
return 0
|
||||
|
||||
|
||||
@@ -1,22 +1,22 @@
|
||||
"""Tenant-partitioned Hermes shared agent fabric primitives."""
|
||||
from __future__ import annotations
|
||||
|
||||
from collections.abc import Callable
|
||||
from contextlib import closing
|
||||
from dataclasses import dataclass
|
||||
from datetime import datetime, timezone
|
||||
import os
|
||||
from contextlib import closing
|
||||
from pathlib import Path
|
||||
import sqlite3
|
||||
from typing import Any, TypeVar
|
||||
from typing import Any
|
||||
|
||||
from .tenant_context import (
|
||||
CanonicalMessage, ConflictError, ScopeError, ValidationError,
|
||||
isoformat, require_ident,
|
||||
CanonicalMessage,
|
||||
ConflictError,
|
||||
ScopeError,
|
||||
ValidationError,
|
||||
isoformat,
|
||||
require_ident,
|
||||
)
|
||||
|
||||
T = TypeVar("T")
|
||||
|
||||
|
||||
@dataclass(frozen=True)
|
||||
class FabricJob:
|
||||
@@ -29,7 +29,9 @@ class FabricJob:
|
||||
status: str = "queued"
|
||||
|
||||
def __post_init__(self) -> None:
|
||||
for name in ("job_id", "cell_id", "profile_id", "session_id", "event_id"):
|
||||
for name in (
|
||||
"job_id", "cell_id", "profile_id", "session_id", "event_id"
|
||||
):
|
||||
require_ident(name, getattr(self, name))
|
||||
require_ident("tenant_id", self.tenant_id, tenant=True)
|
||||
if self.status not in {"queued", "running", "completed", "failed", "cancelled"}:
|
||||
@@ -41,51 +43,34 @@ class HermesFabric:
|
||||
|
||||
def __init__(self, database: str | Path) -> None:
|
||||
self.database = str(database)
|
||||
Path(self.database).parent.mkdir(parents=True, exist_ok=True)
|
||||
self._initialize()
|
||||
os.chmod(self.database, 0o600)
|
||||
|
||||
def _connect(self) -> sqlite3.Connection:
|
||||
db = sqlite3.connect(self.database, timeout=30)
|
||||
db.execute("PRAGMA journal_mode=WAL")
|
||||
db.execute("PRAGMA synchronous=FULL")
|
||||
db.execute("PRAGMA busy_timeout=30000")
|
||||
return db
|
||||
|
||||
def _storage(self, operation: Callable[[], T]) -> T:
|
||||
failure: ConflictError | None = None
|
||||
try:
|
||||
return operation()
|
||||
except sqlite3.Error:
|
||||
failure = ConflictError("fabric storage unavailable")
|
||||
raise failure
|
||||
|
||||
def _initialize(self) -> None:
|
||||
def initialize() -> None:
|
||||
with closing(self._connect()) as connection, connection as db:
|
||||
db.execute(
|
||||
"""
|
||||
CREATE TABLE IF NOT EXISTS fabric_jobs (
|
||||
job_id TEXT PRIMARY KEY,
|
||||
tenant_id TEXT NOT NULL,
|
||||
cell_id TEXT NOT NULL,
|
||||
profile_id TEXT NOT NULL,
|
||||
session_id TEXT NOT NULL,
|
||||
event_id TEXT NOT NULL UNIQUE,
|
||||
status TEXT NOT NULL,
|
||||
created_at TEXT NOT NULL,
|
||||
updated_at TEXT NOT NULL
|
||||
)
|
||||
"""
|
||||
with closing(sqlite3.connect(self.database)) as connection, connection as db:
|
||||
db.execute("PRAGMA journal_mode=WAL")
|
||||
db.execute("PRAGMA synchronous=FULL")
|
||||
db.execute(
|
||||
"""
|
||||
CREATE TABLE IF NOT EXISTS fabric_jobs (
|
||||
job_id TEXT PRIMARY KEY,
|
||||
tenant_id TEXT NOT NULL,
|
||||
cell_id TEXT NOT NULL,
|
||||
profile_id TEXT NOT NULL,
|
||||
session_id TEXT NOT NULL,
|
||||
event_id TEXT NOT NULL UNIQUE,
|
||||
status TEXT NOT NULL,
|
||||
created_at TEXT NOT NULL,
|
||||
updated_at TEXT NOT NULL
|
||||
)
|
||||
db.execute(
|
||||
"CREATE INDEX IF NOT EXISTS idx_fabric_tenant_queue "
|
||||
"ON fabric_jobs(tenant_id, cell_id, status)"
|
||||
)
|
||||
self._storage(initialize)
|
||||
"""
|
||||
)
|
||||
db.execute(
|
||||
"CREATE INDEX IF NOT EXISTS idx_fabric_tenant_queue "
|
||||
"ON fabric_jobs(tenant_id, cell_id, status)"
|
||||
)
|
||||
|
||||
def enqueue(
|
||||
self, *, message: CanonicalMessage, profile_id: str,
|
||||
self,
|
||||
*,
|
||||
message: CanonicalMessage,
|
||||
profile_id: str,
|
||||
) -> FabricJob:
|
||||
profile_id = require_ident("profile_id", profile_id)
|
||||
if not message.command_capable:
|
||||
@@ -93,72 +78,66 @@ class HermesFabric:
|
||||
if not message.is_authenticated_human_command:
|
||||
raise ScopeError("only authenticated human commands can create jobs")
|
||||
job = FabricJob(
|
||||
job_id=f"job-{message.event_id}", tenant_id=message.tenant_id,
|
||||
cell_id=message.cell_id, profile_id=profile_id,
|
||||
session_id=message.session_id, event_id=message.event_id,
|
||||
job_id=f"job-{message.event_id}",
|
||||
tenant_id=message.tenant_id,
|
||||
cell_id=message.cell_id,
|
||||
profile_id=profile_id,
|
||||
session_id=message.session_id,
|
||||
event_id=message.event_id,
|
||||
)
|
||||
now = isoformat()
|
||||
failure: ConflictError | None = None
|
||||
conflict: ConflictError | None = None
|
||||
try:
|
||||
with closing(self._connect()) as connection, connection as db:
|
||||
with closing(sqlite3.connect(self.database)) as connection, connection as db:
|
||||
db.execute("PRAGMA journal_mode=WAL")
|
||||
db.execute(
|
||||
"INSERT INTO fabric_jobs VALUES(?,?,?,?,?,?,?,?,?)",
|
||||
(
|
||||
job.job_id, job.tenant_id, job.cell_id, job.profile_id,
|
||||
job.session_id, job.event_id, job.status, now, now,
|
||||
job.job_id,
|
||||
job.tenant_id,
|
||||
job.cell_id,
|
||||
job.profile_id,
|
||||
job.session_id,
|
||||
job.event_id,
|
||||
job.status,
|
||||
now,
|
||||
now,
|
||||
),
|
||||
)
|
||||
except sqlite3.IntegrityError:
|
||||
failure = ConflictError(
|
||||
conflict = ConflictError(
|
||||
"fabric event already exists or violates queue uniqueness"
|
||||
)
|
||||
except sqlite3.Error:
|
||||
failure = ConflictError("fabric storage unavailable")
|
||||
if failure is not None:
|
||||
raise failure
|
||||
if conflict is not None:
|
||||
raise conflict
|
||||
return job
|
||||
|
||||
def claim(
|
||||
self, tenant_id: str, cell_id: str, profile_id: str,
|
||||
) -> FabricJob | None:
|
||||
tenant_id = require_ident("tenant_id", tenant_id, tenant=True)
|
||||
cell_id = require_ident("cell_id", cell_id)
|
||||
profile_id = require_ident("profile_id", profile_id)
|
||||
|
||||
def claim_one() -> FabricJob | None:
|
||||
with closing(self._connect()) as connection, connection as db:
|
||||
db.execute("BEGIN IMMEDIATE")
|
||||
row = db.execute(
|
||||
"SELECT * FROM fabric_jobs WHERE tenant_id=? AND cell_id=? "
|
||||
"AND profile_id=? AND status='queued' ORDER BY created_at LIMIT 1",
|
||||
(tenant_id, cell_id, profile_id),
|
||||
).fetchone()
|
||||
if not row:
|
||||
db.commit()
|
||||
return None
|
||||
updated = db.execute(
|
||||
"UPDATE fabric_jobs SET status='running', updated_at=? "
|
||||
"WHERE job_id=? AND status='queued'",
|
||||
(isoformat(), row[0]),
|
||||
)
|
||||
if updated.rowcount != 1:
|
||||
db.rollback()
|
||||
return None
|
||||
def claim(self, tenant_id: str, cell_id: str, profile_id: str) -> FabricJob | None:
|
||||
require_ident("tenant_id", tenant_id, tenant=True)
|
||||
require_ident("cell_id", cell_id)
|
||||
require_ident("profile_id", profile_id)
|
||||
with closing(sqlite3.connect(self.database)) as connection, connection as db:
|
||||
db.execute("BEGIN IMMEDIATE")
|
||||
row = db.execute(
|
||||
"SELECT * FROM fabric_jobs WHERE tenant_id=? AND cell_id=? "
|
||||
"AND profile_id=? AND status='queued' ORDER BY created_at LIMIT 1",
|
||||
(tenant_id, cell_id, profile_id),
|
||||
).fetchone()
|
||||
if not row:
|
||||
db.commit()
|
||||
return FabricJob(
|
||||
job_id=row[0], tenant_id=row[1], cell_id=row[2],
|
||||
profile_id=row[3], session_id=row[4], event_id=row[5],
|
||||
status="running",
|
||||
)
|
||||
|
||||
return self._storage(claim_one)
|
||||
return None
|
||||
db.execute(
|
||||
"UPDATE fabric_jobs SET status='running', updated_at=? WHERE job_id=?",
|
||||
(isoformat(), row[0]),
|
||||
)
|
||||
db.commit()
|
||||
return FabricJob(*row[:7])
|
||||
|
||||
def health(self) -> dict[str, Any]:
|
||||
def query() -> int:
|
||||
with closing(self._connect()) as connection, connection as db:
|
||||
return int(db.execute("SELECT count(*) FROM fabric_jobs").fetchone()[0])
|
||||
|
||||
with closing(sqlite3.connect(self.database)) as connection, connection as db:
|
||||
count = db.execute("SELECT count(*) FROM fabric_jobs").fetchone()[0]
|
||||
return {
|
||||
"component": "hermes_fabric", "jobs": self._storage(query),
|
||||
"component": "hermes_fabric",
|
||||
"jobs": count,
|
||||
"checked_at": datetime.now(timezone.utc).isoformat(),
|
||||
}
|
||||
|
||||
@@ -1,9 +1,9 @@
|
||||
"""Hermes shared-fabric profile isolation primitives."""
|
||||
"""Hermes shared fabric profile isolation primitives."""
|
||||
from __future__ import annotations
|
||||
|
||||
from dataclasses import dataclass
|
||||
import os
|
||||
from pathlib import Path
|
||||
import os
|
||||
|
||||
from .tenant_context import ValidationError, require_ident
|
||||
|
||||
@@ -20,12 +20,7 @@ class HermesProfile:
|
||||
require_ident("tenant_id", self.tenant_id, tenant=True)
|
||||
for name in ("cell_id", "profile_id"):
|
||||
require_ident(name, getattr(self, name))
|
||||
if (
|
||||
not isinstance(self.hermes_home, Path)
|
||||
or not isinstance(self.workspace, Path)
|
||||
or not self.hermes_home.is_absolute()
|
||||
or not self.workspace.is_absolute()
|
||||
):
|
||||
if not self.hermes_home.is_absolute() or not self.workspace.is_absolute():
|
||||
raise ValidationError("profile paths must be absolute")
|
||||
|
||||
@property
|
||||
@@ -38,28 +33,13 @@ class HermesProfile:
|
||||
"AIOS_PROFILE_ID": self.profile_id,
|
||||
}
|
||||
|
||||
@staticmethod
|
||||
def _reject_symlink_components(root: Path) -> None:
|
||||
current = Path(root.anchor)
|
||||
for part in root.parts[1:]:
|
||||
current = current / part
|
||||
if current.is_symlink():
|
||||
raise ValidationError("profile root contains symlink")
|
||||
|
||||
def _validate_roots(self) -> None:
|
||||
for root in (self.hermes_home, self.workspace):
|
||||
self._reject_symlink_components(root)
|
||||
|
||||
def prepare(self) -> None:
|
||||
self._validate_roots()
|
||||
for root in (self.hermes_home, self.workspace):
|
||||
root.mkdir(parents=True, exist_ok=True)
|
||||
self._validate_roots()
|
||||
for root in (self.hermes_home, self.workspace):
|
||||
os.chmod(root, 0o700)
|
||||
self.hermes_home.mkdir(parents=True, exist_ok=True)
|
||||
self.workspace.mkdir(parents=True, exist_ok=True)
|
||||
os.chmod(self.hermes_home, 0o700)
|
||||
os.chmod(self.workspace, 0o700)
|
||||
|
||||
def assert_path_allowed(self, path: str | Path) -> None:
|
||||
self._validate_roots()
|
||||
target = Path(path).resolve()
|
||||
for root in (self.hermes_home.resolve(), self.workspace.resolve()):
|
||||
if target == root or root in target.parents:
|
||||
|
||||
@@ -50,7 +50,6 @@ class IngressHTTPServer(ThreadingHTTPServer):
|
||||
self._lifecycle_lock = threading.RLock()
|
||||
self._connections_lock = threading.Lock()
|
||||
self._connections: set[socket.socket] = set()
|
||||
self._server_close_lock = threading.Lock()
|
||||
self.processor = processor
|
||||
super().__init__(address, handler)
|
||||
|
||||
@@ -58,71 +57,22 @@ class IngressHTTPServer(ThreadingHTTPServer):
|
||||
def is_closing(self) -> bool:
|
||||
return self._closing.is_set()
|
||||
|
||||
def get_request(self) -> tuple[socket.socket, tuple[str, int]]:
|
||||
"""Register each accepted socket before handler scheduling can begin."""
|
||||
connection, client_address = super().get_request()
|
||||
with self._lifecycle_lock:
|
||||
if self._closing.is_set():
|
||||
reject = True
|
||||
else:
|
||||
with self._connections_lock:
|
||||
self._connections.add(connection)
|
||||
reject = False
|
||||
if reject:
|
||||
self._shutdown_and_close_connection(connection)
|
||||
raise OSError("server is closing")
|
||||
return connection, client_address
|
||||
def register_connection(self, connection: socket.socket) -> None:
|
||||
with self._connections_lock:
|
||||
self._connections.add(connection)
|
||||
|
||||
def unregister_connection(self, connection: socket.socket) -> None:
|
||||
with self._connections_lock:
|
||||
self._connections.discard(connection)
|
||||
|
||||
def _shutdown_and_close_connection(self, connection: socket.socket) -> None:
|
||||
try:
|
||||
connection.shutdown(socket.SHUT_RDWR)
|
||||
except OSError:
|
||||
pass
|
||||
try:
|
||||
connection.close()
|
||||
except OSError:
|
||||
pass
|
||||
finally:
|
||||
self.unregister_connection(connection)
|
||||
|
||||
def _close_accepted_connections(self) -> None:
|
||||
def _interrupt_active_reads(self) -> None:
|
||||
with self._connections_lock:
|
||||
connections = tuple(self._connections)
|
||||
for connection in connections:
|
||||
self._shutdown_and_close_connection(connection)
|
||||
|
||||
def process_request(
|
||||
self,
|
||||
request: socket.socket,
|
||||
client_address: tuple[str, int],
|
||||
) -> None:
|
||||
"""Linearize request admission with the transition to closing."""
|
||||
with self._lifecycle_lock:
|
||||
if self._closing.is_set():
|
||||
reject = True
|
||||
else:
|
||||
reject = False
|
||||
try:
|
||||
super().process_request(request, client_address)
|
||||
except Exception:
|
||||
self._shutdown_and_close_connection(request)
|
||||
raise
|
||||
if reject:
|
||||
self._shutdown_and_close_connection(request)
|
||||
|
||||
def shutdown_request(self, request: socket.socket) -> None:
|
||||
try:
|
||||
request.shutdown(socket.SHUT_RDWR)
|
||||
except OSError:
|
||||
pass
|
||||
try:
|
||||
super().shutdown_request(request)
|
||||
finally:
|
||||
self.unregister_connection(request)
|
||||
try:
|
||||
connection.shutdown(socket.SHUT_RD)
|
||||
except OSError:
|
||||
pass
|
||||
|
||||
def call_processor(self, path: str, body: bytes) -> tuple[bool, Any]:
|
||||
"""Start processing atomically with respect to server shutdown."""
|
||||
@@ -131,21 +81,17 @@ class IngressHTTPServer(ThreadingHTTPServer):
|
||||
return False, None
|
||||
return True, self.processor(path, body)
|
||||
|
||||
def _begin_closing(self) -> None:
|
||||
def shutdown(self) -> None:
|
||||
with self._lifecycle_lock:
|
||||
self._closing.set()
|
||||
|
||||
def shutdown(self) -> None:
|
||||
self._begin_closing()
|
||||
self._close_accepted_connections()
|
||||
self._interrupt_active_reads()
|
||||
super().shutdown()
|
||||
|
||||
def server_close(self) -> None:
|
||||
"""Interrupt accepted sockets before the base class joins handlers."""
|
||||
with self._server_close_lock:
|
||||
self._begin_closing()
|
||||
self._close_accepted_connections()
|
||||
super().server_close()
|
||||
with self._lifecycle_lock:
|
||||
self._closing.set()
|
||||
self._interrupt_active_reads()
|
||||
super().server_close()
|
||||
|
||||
def handle_error(
|
||||
self,
|
||||
@@ -212,6 +158,7 @@ class IngressRequestHandler(BaseHTTPRequestHandler):
|
||||
self._network_read_deadline: float | None = None
|
||||
self._network_read_timer: threading.Timer | None = None
|
||||
self._network_read_active = False
|
||||
self.server.register_connection(self.connection)
|
||||
|
||||
def finish(self) -> None:
|
||||
self._complete_network_read()
|
||||
@@ -219,6 +166,8 @@ class IngressRequestHandler(BaseHTTPRequestHandler):
|
||||
super().finish()
|
||||
except OSError:
|
||||
pass
|
||||
finally:
|
||||
self.server.unregister_connection(self.connection)
|
||||
|
||||
def _start_network_read(self) -> None:
|
||||
self._complete_network_read()
|
||||
|
||||
@@ -7,6 +7,7 @@ from typing import Literal
|
||||
|
||||
from .tenant_context import ScopeError, ValidationError, require_ident
|
||||
|
||||
|
||||
MemoryKind = Literal["session", "profile", "cell", "tenant", "shared_artifact"]
|
||||
|
||||
|
||||
@@ -48,8 +49,6 @@ class MemoryScope:
|
||||
if write:
|
||||
raise ScopeError("shared artifacts are immutable")
|
||||
return
|
||||
if self.kind != requested.kind:
|
||||
raise ScopeError("cross-kind memory access denied")
|
||||
if self.profile_id != requested.profile_id and requested.kind in {"profile", "session"}:
|
||||
raise ScopeError("cross-profile memory access denied")
|
||||
if requested.kind == "session" and self.session_id != requested.session_id:
|
||||
@@ -57,7 +56,5 @@ class MemoryScope:
|
||||
|
||||
|
||||
def qualify_memory_key(scope: MemoryScope, key: str) -> str:
|
||||
normalized = require_ident("memory_key", key)
|
||||
if normalized != key:
|
||||
raise ValidationError("memory_key must be canonical")
|
||||
return f"{scope.namespace}/{normalized}"
|
||||
key = require_ident("memory_key", key)
|
||||
return f"{scope.namespace}/{key}"
|
||||
|
||||
@@ -1,22 +1,25 @@
|
||||
"""Tenant-scoped append-only message ledger and exact quote resolver."""
|
||||
from __future__ import annotations
|
||||
|
||||
from collections.abc import Callable
|
||||
from contextlib import closing
|
||||
from dataclasses import dataclass
|
||||
from datetime import timedelta
|
||||
from contextlib import closing
|
||||
import os
|
||||
from pathlib import Path
|
||||
import sqlite3
|
||||
from typing import TypeVar
|
||||
from typing import Iterable
|
||||
|
||||
from .tenant_context import (
|
||||
CanonicalMessage, ConflictError, ScopeError, ValidationError,
|
||||
isoformat, normalize_message_id, utc_now,
|
||||
CanonicalMessage,
|
||||
ConflictError,
|
||||
ScopeError,
|
||||
ValidationError,
|
||||
isoformat,
|
||||
normalize_message_id,
|
||||
parse_time,
|
||||
utc_now,
|
||||
)
|
||||
|
||||
T = TypeVar("T")
|
||||
|
||||
|
||||
@dataclass(frozen=True)
|
||||
class LedgerRecord:
|
||||
@@ -34,7 +37,11 @@ class LedgerRecord:
|
||||
|
||||
|
||||
class MessageLedger:
|
||||
"""Exact-ID ledger with no fuzzy, prefix, or time-nearest fallback."""
|
||||
"""Exact-ID ledger.
|
||||
|
||||
The resolver never uses time windows, prefixes, similarity, or nearest-message
|
||||
fallbacks. Ambiguity and absence fail closed.
|
||||
"""
|
||||
|
||||
def __init__(self, database: str | Path, *, ttl_days: int = 7) -> None:
|
||||
if not 1 <= ttl_days <= 365:
|
||||
@@ -56,64 +63,64 @@ class MessageLedger:
|
||||
db.execute("PRAGMA busy_timeout=30000")
|
||||
return db
|
||||
|
||||
def _storage(self, operation: Callable[[], T]) -> T:
|
||||
failure: ConflictError | None = None
|
||||
try:
|
||||
return operation()
|
||||
except sqlite3.Error:
|
||||
failure = ConflictError("ledger storage unavailable")
|
||||
# Raise after the driver exception handler, keeping SQLite details out of
|
||||
# both the public exception and its implicit context.
|
||||
raise failure
|
||||
|
||||
def _initialize(self) -> None:
|
||||
def initialize() -> None:
|
||||
with closing(self._connect()) as connection, connection as db:
|
||||
db.executescript(
|
||||
"""
|
||||
CREATE TABLE IF NOT EXISTS message_ledger (
|
||||
tenant_id TEXT NOT NULL,
|
||||
cell_id TEXT NOT NULL,
|
||||
channel TEXT NOT NULL,
|
||||
channel_account_id TEXT NOT NULL,
|
||||
peer_id TEXT NOT NULL,
|
||||
direction TEXT NOT NULL CHECK(direction IN ('inbound','outbound','internal')),
|
||||
message_id TEXT NOT NULL,
|
||||
event_id TEXT NOT NULL,
|
||||
body TEXT NOT NULL,
|
||||
occurred_at TEXT NOT NULL,
|
||||
expires_at TEXT NOT NULL,
|
||||
created_at TEXT NOT NULL,
|
||||
PRIMARY KEY(
|
||||
tenant_id, cell_id, channel, channel_account_id,
|
||||
peer_id, direction, message_id
|
||||
),
|
||||
UNIQUE(tenant_id, cell_id, event_id)
|
||||
);
|
||||
CREATE INDEX IF NOT EXISTS idx_message_reply_lookup ON message_ledger(
|
||||
tenant_id, cell_id, channel, channel_account_id,
|
||||
peer_id, message_id, expires_at
|
||||
);
|
||||
"""
|
||||
)
|
||||
self._storage(initialize)
|
||||
with closing(self._connect()) as connection, connection as db:
|
||||
db.executescript(
|
||||
"""
|
||||
CREATE TABLE IF NOT EXISTS message_ledger (
|
||||
tenant_id TEXT NOT NULL,
|
||||
cell_id TEXT NOT NULL,
|
||||
channel TEXT NOT NULL,
|
||||
channel_account_id TEXT NOT NULL,
|
||||
peer_id TEXT NOT NULL,
|
||||
direction TEXT NOT NULL CHECK(direction IN ('inbound','outbound','internal')),
|
||||
message_id TEXT NOT NULL,
|
||||
event_id TEXT NOT NULL,
|
||||
body TEXT NOT NULL,
|
||||
occurred_at TEXT NOT NULL,
|
||||
expires_at TEXT NOT NULL,
|
||||
created_at TEXT NOT NULL,
|
||||
PRIMARY KEY(
|
||||
tenant_id, cell_id, channel, channel_account_id,
|
||||
peer_id, direction, message_id
|
||||
),
|
||||
UNIQUE(tenant_id, cell_id, event_id)
|
||||
);
|
||||
CREATE INDEX IF NOT EXISTS idx_message_reply_lookup ON message_ledger(
|
||||
tenant_id, cell_id, channel, channel_account_id,
|
||||
peer_id, message_id, expires_at
|
||||
);
|
||||
"""
|
||||
)
|
||||
|
||||
def append(self, message: CanonicalMessage) -> LedgerRecord:
|
||||
"""Append one exact message through the runtime write path.
|
||||
|
||||
This is intentionally the owner of validation, idempotency, and the
|
||||
immediate SQLite transaction. Runtime callers must not depend on the
|
||||
legacy ``remember`` compatibility name.
|
||||
"""
|
||||
message_id = normalize_message_id(message.message_id)
|
||||
now = utc_now()
|
||||
expires = isoformat(now + timedelta(days=self.ttl_days))
|
||||
key = (
|
||||
message.tenant_id, message.cell_id, message.channel,
|
||||
message.channel_account_id, message.peer_id, message.direction, message_id,
|
||||
message.tenant_id,
|
||||
message.cell_id,
|
||||
message.channel,
|
||||
message.channel_account_id,
|
||||
message.peer_id,
|
||||
message.direction,
|
||||
message_id,
|
||||
)
|
||||
|
||||
def write() -> LedgerRecord:
|
||||
storage_error: ConflictError | None = None
|
||||
try:
|
||||
with closing(self._connect()) as connection, connection as db:
|
||||
db.execute("BEGIN IMMEDIATE")
|
||||
existing = db.execute(
|
||||
"SELECT event_id, body, occurred_at, expires_at FROM message_ledger "
|
||||
"WHERE tenant_id=? AND cell_id=? AND channel=? AND channel_account_id=? "
|
||||
"AND peer_id=? AND direction=? AND message_id=?", key,
|
||||
"AND peer_id=? AND direction=? AND message_id=?",
|
||||
key,
|
||||
).fetchone()
|
||||
if existing:
|
||||
if existing["body"] != message.body:
|
||||
@@ -126,56 +133,50 @@ class MessageLedger:
|
||||
)
|
||||
db.execute(
|
||||
"INSERT INTO message_ledger VALUES(?,?,?,?,?,?,?,?,?,?,?,?)",
|
||||
(*key, message.event_id, message.body, message.occurred_at,
|
||||
expires, isoformat(now)),
|
||||
(*key, message.event_id, message.body, message.occurred_at, expires, isoformat(now)),
|
||||
)
|
||||
db.commit()
|
||||
return LedgerRecord(
|
||||
*key, message.event_id, message.body, message.occurred_at, expires
|
||||
)
|
||||
|
||||
return self._storage(write)
|
||||
except sqlite3.Error:
|
||||
storage_error = ConflictError("ledger storage unavailable")
|
||||
if storage_error is not None:
|
||||
# Raise outside the sqlite exception handler so callers cannot inspect
|
||||
# a driver exception through __cause__ or __context__.
|
||||
raise storage_error
|
||||
return LedgerRecord(*key, message.event_id, message.body, message.occurred_at, expires)
|
||||
|
||||
def remember(self, message: CanonicalMessage) -> LedgerRecord:
|
||||
"""Backward-compatible API wrapper outside the runtime write path."""
|
||||
"""Backward-compatible API wrapper for callers outside the runtime path."""
|
||||
return self.append(message)
|
||||
|
||||
def matches(self, message: CanonicalMessage) -> bool:
|
||||
"""Whether this exact message is already durably represented."""
|
||||
message_id = normalize_message_id(message.message_id)
|
||||
|
||||
def query() -> bool:
|
||||
with closing(self._connect()) as connection, connection as db:
|
||||
row = db.execute(
|
||||
"SELECT event_id, body FROM message_ledger WHERE tenant_id=? AND "
|
||||
"cell_id=? AND channel=? AND channel_account_id=? AND peer_id=? "
|
||||
"AND direction=? AND message_id=?",
|
||||
(
|
||||
message.tenant_id, message.cell_id, message.channel,
|
||||
message.channel_account_id, message.peer_id, message.direction,
|
||||
message_id,
|
||||
),
|
||||
).fetchone()
|
||||
return bool(
|
||||
row and row["event_id"] == message.event_id
|
||||
and row["body"] == message.body
|
||||
)
|
||||
|
||||
return self._storage(query)
|
||||
with closing(self._connect()) as connection, connection as db:
|
||||
row = db.execute(
|
||||
"SELECT event_id, body FROM message_ledger WHERE tenant_id=? AND "
|
||||
"cell_id=? AND channel=? AND channel_account_id=? AND peer_id=? "
|
||||
"AND direction=? AND message_id=?",
|
||||
(
|
||||
message.tenant_id, message.cell_id, message.channel,
|
||||
message.channel_account_id, message.peer_id, message.direction,
|
||||
message_id,
|
||||
),
|
||||
).fetchone()
|
||||
return bool(row and row["event_id"] == message.event_id and row["body"] == message.body)
|
||||
|
||||
def remove(self, record: LedgerRecord) -> None:
|
||||
def delete() -> None:
|
||||
with closing(self._connect()) as connection, connection as db:
|
||||
db.execute(
|
||||
"DELETE FROM message_ledger WHERE tenant_id=? AND cell_id=? AND "
|
||||
"channel=? AND channel_account_id=? AND peer_id=? AND direction=? "
|
||||
"AND message_id=? AND event_id=?",
|
||||
(
|
||||
record.tenant_id, record.cell_id, record.channel,
|
||||
record.channel_account_id, record.peer_id, record.direction,
|
||||
record.message_id, record.event_id,
|
||||
),
|
||||
)
|
||||
self._storage(delete)
|
||||
"""Compensate a newly appended record if a later ingress step fails."""
|
||||
with closing(self._connect()) as connection, connection as db:
|
||||
db.execute(
|
||||
"DELETE FROM message_ledger WHERE tenant_id=? AND cell_id=? AND "
|
||||
"channel=? AND channel_account_id=? AND peer_id=? AND direction=? "
|
||||
"AND message_id=? AND event_id=?",
|
||||
(
|
||||
record.tenant_id, record.cell_id, record.channel,
|
||||
record.channel_account_id, record.peer_id, record.direction,
|
||||
record.message_id, record.event_id,
|
||||
),
|
||||
)
|
||||
|
||||
def resolve_quote(self, message: CanonicalMessage) -> str:
|
||||
if message.quoted_body is not None:
|
||||
@@ -183,22 +184,24 @@ class MessageLedger:
|
||||
if message.reply_to_message_id is None:
|
||||
raise ScopeError("quoted_text_unavailable")
|
||||
reply_id = normalize_message_id(
|
||||
message.reply_to_message_id, field_name="reply_to_message_id"
|
||||
message.reply_to_message_id,
|
||||
field_name="reply_to_message_id",
|
||||
)
|
||||
|
||||
def query() -> list[sqlite3.Row]:
|
||||
with closing(self._connect()) as connection, connection as db:
|
||||
return db.execute(
|
||||
"SELECT direction, body, event_id FROM message_ledger "
|
||||
"WHERE tenant_id=? AND cell_id=? AND channel=? AND channel_account_id=? "
|
||||
"AND peer_id=? AND message_id=? AND expires_at>?",
|
||||
(
|
||||
message.tenant_id, message.cell_id, message.channel,
|
||||
message.channel_account_id, message.peer_id, reply_id, isoformat(),
|
||||
),
|
||||
).fetchall()
|
||||
|
||||
rows = self._storage(query)
|
||||
with closing(self._connect()) as connection, connection as db:
|
||||
rows = db.execute(
|
||||
"SELECT direction, body, event_id FROM message_ledger "
|
||||
"WHERE tenant_id=? AND cell_id=? AND channel=? AND channel_account_id=? "
|
||||
"AND peer_id=? AND message_id=? AND expires_at>?",
|
||||
(
|
||||
message.tenant_id,
|
||||
message.cell_id,
|
||||
message.channel,
|
||||
message.channel_account_id,
|
||||
message.peer_id,
|
||||
reply_id,
|
||||
isoformat(),
|
||||
),
|
||||
).fetchall()
|
||||
if len(rows) == 1:
|
||||
return str(rows[0]["body"])
|
||||
if len(rows) > 1:
|
||||
@@ -206,22 +209,16 @@ class MessageLedger:
|
||||
raise ScopeError("quoted_text_unavailable")
|
||||
|
||||
def purge_expired(self) -> int:
|
||||
def purge() -> int:
|
||||
with closing(self._connect()) as connection, connection as db:
|
||||
cursor = db.execute(
|
||||
"DELETE FROM message_ledger WHERE expires_at<=?", (isoformat(),)
|
||||
)
|
||||
return cursor.rowcount
|
||||
return self._storage(purge)
|
||||
with closing(self._connect()) as connection, connection as db:
|
||||
cursor = db.execute(
|
||||
"DELETE FROM message_ledger WHERE expires_at<=?", (isoformat(),)
|
||||
)
|
||||
return cursor.rowcount
|
||||
|
||||
def integrity_check(self) -> str:
|
||||
def check() -> str:
|
||||
with closing(self._connect()) as connection, connection as db:
|
||||
return str(db.execute("PRAGMA integrity_check").fetchone()[0])
|
||||
return self._storage(check)
|
||||
with closing(self._connect()) as connection, connection as db:
|
||||
return str(db.execute("PRAGMA integrity_check").fetchone()[0])
|
||||
|
||||
def count(self) -> int:
|
||||
def query() -> int:
|
||||
with closing(self._connect()) as connection, connection as db:
|
||||
return int(db.execute("SELECT count(*) FROM message_ledger").fetchone()[0])
|
||||
return self._storage(query)
|
||||
with closing(self._connect()) as connection, connection as db:
|
||||
return int(db.execute("SELECT count(*) FROM message_ledger").fetchone()[0])
|
||||
|
||||
@@ -1,10 +1,14 @@
|
||||
"""Tenant and Cell scoped, value-free secret reference model."""
|
||||
"""Tenant and Cell scoped secret reference model.
|
||||
|
||||
This module never stores secret values. It stores ownership and retrieval scope
|
||||
metadata for integration with a real secret broker.
|
||||
"""
|
||||
from __future__ import annotations
|
||||
|
||||
from dataclasses import dataclass
|
||||
from typing import Any, Literal
|
||||
from typing import Literal
|
||||
|
||||
from .tenant_context import ScopeError, ValidationError, require_ident
|
||||
from .tenant_context import ValidationError, require_ident
|
||||
|
||||
|
||||
@dataclass(frozen=True)
|
||||
@@ -18,44 +22,12 @@ class SecretRef:
|
||||
|
||||
def __post_init__(self) -> None:
|
||||
for name in ("secret_id", "cell_id", "version"):
|
||||
value = getattr(self, name)
|
||||
if require_ident(name, value) != value:
|
||||
raise ValidationError(f"{name} must be canonical")
|
||||
if require_ident("tenant_id", self.tenant_id, tenant=True) != self.tenant_id:
|
||||
raise ValidationError("tenant_id must be canonical")
|
||||
require_ident(name, getattr(self, name))
|
||||
require_ident("tenant_id", self.tenant_id, tenant=True)
|
||||
if self.kind not in {"channel", "model", "tool", "runtime"}:
|
||||
raise ValidationError("invalid secret kind")
|
||||
self._validate_broker_path()
|
||||
|
||||
def _validate_broker_path(self) -> None:
|
||||
if not isinstance(self.broker_path, str) or not self.broker_path.startswith("secret://"):
|
||||
if not self.broker_path.startswith("secret://"):
|
||||
raise ValidationError("secret broker path required")
|
||||
suffix = self.broker_path[len("secret://"):]
|
||||
if (
|
||||
not suffix or "?" in suffix or "#" in suffix or chr(92) in suffix
|
||||
or any(part in {"", ".", ".."} for part in suffix.split("/"))
|
||||
):
|
||||
raise ValidationError("invalid secret broker path")
|
||||
for part in suffix.split("/"):
|
||||
if require_ident("secret broker path segment", part) != part:
|
||||
raise ValidationError("invalid secret broker path")
|
||||
|
||||
def can_be_used_by(self, *, tenant_id: str, cell_id: str) -> bool:
|
||||
return self.tenant_id == tenant_id and self.cell_id == cell_id
|
||||
|
||||
def resolve(self, broker: Any) -> str:
|
||||
"""Resolve through one explicit broker boundary without leaking provider errors."""
|
||||
failure: ScopeError | None = None
|
||||
value: object = None
|
||||
try:
|
||||
reader = getattr(broker, "read_secret")
|
||||
if not callable(reader):
|
||||
raise TypeError("invalid broker")
|
||||
value = reader(self)
|
||||
if not isinstance(value, str) or not value:
|
||||
raise ValueError("invalid broker result")
|
||||
except Exception:
|
||||
failure = ScopeError("secret broker unavailable")
|
||||
if failure is not None:
|
||||
raise failure
|
||||
return value
|
||||
|
||||
@@ -18,14 +18,12 @@
|
||||
- All OpenClaw loader work uses an isolated temporary or candidate config/state directory.
|
||||
- `ACCEPTED` is terminal. Legacy handling is reachable only when bridge mode is explicitly `disabled`.
|
||||
- Never claim exactly-once Hermes delivery or use time/approximation as message authority.
|
||||
- D0 is a non-blocker documentation correction. Its reviewed commit is the R9 `START`; it does not consume a blocker label or relax any B3/B4/B5 evidence gate.
|
||||
- B2 is both the canonical-package blocker and the executable completeness gate for Ledger, Memory, Secret, Audit, Hermes Profile, Cell Manager/CLI, and Fabric. Existing correct behavior is recorded as characterization; a production edit requires an observed contract RED first.
|
||||
|
||||
After docs review, initialize the stable per-worktree ledger from the then-current tip rather than a hardcoded SHA:
|
||||
|
||||
```bash
|
||||
test -z "$(git status --porcelain)"
|
||||
test "$(git branch --show-current)" = "integration/v2r1-runtime-20260715-r9"
|
||||
test "$(git branch --show-current)" = "integration/v2r1-runtime-20260714"
|
||||
start_sha="$(git rev-parse HEAD)"
|
||||
start_parent="$(git rev-parse HEAD^)"
|
||||
start_tree="$(git rev-parse HEAD^{tree})"
|
||||
@@ -172,24 +170,8 @@ test "$tree" = "$(git rev-parse HEAD^{tree})"
|
||||
- Create: `tests/v2r1/test_ingress_service.py`
|
||||
- Create: `tests/test_v2r1_package_identity.py`
|
||||
- Modify: the exact 23 Appendix A test files, and no unlisted legacy import file
|
||||
- Modify only after an observed matrix RED: `active-runtime/app/aios_v2r1/message_ledger.py`
|
||||
- Modify only after an observed matrix RED: `active-runtime/app/aios_v2r1/memory_scope.py`
|
||||
- Modify only after an observed matrix RED: `active-runtime/app/aios_v2r1/secret_scope.py`
|
||||
- Modify only after an observed matrix RED: `active-runtime/app/aios_v2r1/audit.py`
|
||||
- Modify only after an observed matrix RED: `active-runtime/app/aios_v2r1/hermes_profile.py`
|
||||
- Modify only after an observed matrix RED: `active-runtime/app/aios_v2r1/cell_manager.py`
|
||||
- Modify only after an observed matrix RED: `active-runtime/app/aios_v2r1/hermes_fabric.py`
|
||||
- Expand: `tests/v2r1/test_message_ledger_append.py`
|
||||
- Create: `tests/v2r1/test_memory_scope.py`
|
||||
- Create: `tests/v2r1/test_secret_scope.py`
|
||||
- Create: `tests/v2r1/test_audit.py`
|
||||
- Create: `tests/v2r1/test_hermes_profile.py`
|
||||
- Create: `tests/v2r1/test_cell_manager.py`
|
||||
- Expand: `tests/v2r1/test_hermes_fabric.py`
|
||||
|
||||
**Exact contract:** V2R1 imports only as `aios_v2r1`; no `active_runtime` shim/alias/namespace extension/copied tree. Wheel includes `aios_v2r1`, excludes `active_runtime` and legacy `app`. Legacy repository tests change `active_runtime.app.*` to `app.*` and run with `PYTHONPATH='active-runtime:active-runtime/app'`. Mutation routes return bounded `SERVICE_NOT_CONFIGURED` until B3/B4 processors exist. Existing cell CLI stays compatible and `serve` is separate. B2 changes exactly 43 paths: the original 29 package/import paths plus the seven named runtime modules and seven named matrix-test paths above.
|
||||
|
||||
**Executable completeness matrix:** Message Ledger proves exact-ID query with no fallback, idempotency, collision conflict, tenant/cell/direction isolation, expiry/purge, restart, concurrency, and sanitized SQLite failures. Memory proves every namespace, cross-scope denial, shared-artifact read-only access, qualified keys, traversal rejection, and disabled search. Secret proves reference/path/scope/kind/version/identifier validation, no value leakage, and fail-closed broker boundaries. Audit proves genesis, tamper/delete/reorder detection, Unicode canonicalization, concurrency, restart, validation, tenant isolation, and sanitized SQLite failures. Hermes Profile proves exact environment, absolute roots, `0700` modes, traversal/symlink denial, scope, idempotent prepare, and no inherited environment. Cell Manager/CLI proves one cell per tenant, an explicit state graph, atomic/concurrent persistence, corrupt-registry fail-closed behavior, stable CLI exit codes/JSON, and restart. Fabric proves claimed jobs return `running` consistently with durable state, tenant/cell/profile isolation, one concurrent claimant, rejection of non-claimable states, restart, and sanitized SQLite failures.
|
||||
**Exact contract:** V2R1 imports only as `aios_v2r1`; no `active_runtime` shim/alias/namespace extension/copied tree. Wheel includes `aios_v2r1`, excludes `active_runtime` and legacy `app`. Legacy repository tests change `active_runtime.app.*` to `app.*` and run with `PYTHONPATH='active-runtime:active-runtime/app'`. Mutation routes return bounded `SERVICE_NOT_CONFIGURED` until B3/B4 processors exist. Existing cell CLI stays compatible and `serve` is separate.
|
||||
|
||||
- [ ] Rehydrate the stable blocker ledger using the global snippet and require its latest label is `B1`.
|
||||
- [ ] Rehydrate the exact explorer manifest path and compare sorted actual/expected lists between exact marker lines. The marker names are assembled from split literals so this command cannot match itself:
|
||||
@@ -214,21 +196,16 @@ cmp -s "$actual" "$expected"
|
||||
|
||||
Expected: exact match to 23 paths. Drift requires another docs review.
|
||||
|
||||
- [ ] Add package/service/CLI tests and the seven-component matrix before any production repair. Run each focused case and record the exact command plus its expected contract failure. If current behavior already satisfies the contract, record it as characterization and do not manufacture a failure or edit that production module.
|
||||
- [ ] Run the aggregate initial RED/characterization command:
|
||||
- [ ] Add package/service/CLI tests; run initial RED:
|
||||
|
||||
```bash
|
||||
PYTHONDONTWRITEBYTECODE=1 PYTEST_ADDOPTS='-p no:cacheprovider' PYTHONPATH='active-runtime:active-runtime/app' \
|
||||
python3 -m pytest tests/v2r1/test_ingress_service.py tests/test_v2r1_package_identity.py \
|
||||
tests/v2r1/test_message_ledger_append.py tests/v2r1/test_memory_scope.py \
|
||||
tests/v2r1/test_secret_scope.py tests/v2r1/test_audit.py \
|
||||
tests/v2r1/test_hermes_profile.py tests/v2r1/test_cell_manager.py \
|
||||
tests/v2r1/test_hermes_fabric.py -q
|
||||
python3 -m pytest tests/v2r1/test_ingress_service.py tests/test_v2r1_package_identity.py -q
|
||||
```
|
||||
|
||||
Expected: package metadata, ingress service, and identity tests begin RED because their implementation is absent. Each matrix case is either a recorded contract RED or a recorded characterization; no production repair precedes its corresponding RED.
|
||||
Expected RED: package metadata, ingress service, and identity tests do not exist.
|
||||
|
||||
- [ ] Implement package/disabled processor boundary and replace imports in exactly Appendix A. Apply only the minimum runtime repairs demonstrated by matrix REDs; do not delete or weaken a matrix test. Prove no shim/old import:
|
||||
- [ ] Implement package/disabled processor boundary and replace imports in exactly Appendix A. Prove no shim/old import:
|
||||
|
||||
```bash
|
||||
test ! -e active_runtime
|
||||
@@ -238,15 +215,11 @@ test -z "$(git grep -l -E '^(from|import) active_runtime\.app' -- tests || true)
|
||||
- [ ] Run full collect and full suite:
|
||||
|
||||
```bash
|
||||
PYTHONDONTWRITEBYTECODE=1 PYTEST_ADDOPTS='-p no:cacheprovider' PYTHONPATH='active-runtime:active-runtime/app' \
|
||||
python3 -m pytest tests/v2r1 tests/integration tests/test_v2r1_package_identity.py -q
|
||||
PYTHONDONTWRITEBYTECODE=1 PYTEST_ADDOPTS='-p no:cacheprovider' PYTHONPATH='active-runtime:active-runtime/app' python3 -m pytest --collect-only -q
|
||||
PYTHONDONTWRITEBYTECODE=1 PYTEST_ADDOPTS='-p no:cacheprovider' PYTHONPATH='active-runtime:active-runtime/app' python3 -m pytest -q
|
||||
PYTHONDONTWRITEBYTECODE=1 python3 -m compileall -q active-runtime/app/aios_v2r1
|
||||
(cd openclaw/plugins/aios-tenant-boundary && npm test)
|
||||
```
|
||||
|
||||
Expected GREEN: the focused carried suite reports at least `160 passed`, including every matrix bullet; full collection has zero import errors; the complete pytest suite, 15 Node tests, and Python compileall pass. Re-run B1's real isolated default/opt-in loader sequence and require the same hook evidence. Pre-existing failures still block B2.
|
||||
Expected GREEN: zero collection/import errors and complete suite passes; pre-existing failures still block B2.
|
||||
|
||||
- [ ] Build and inspect isolated wheel:
|
||||
|
||||
@@ -268,29 +241,22 @@ PY
|
||||
|
||||
Expected GREEN: one wheel, one V2R1 namespace, installed identity `aios_v2r1`.
|
||||
|
||||
- [ ] Stage the exact 43 paths (six package paths, Appendix A's 23 import paths, seven matrix runtime modules, and seven matrix-test paths), commit, append ledger:
|
||||
- [ ] Stage six named paths plus exact explorer list, commit, append ledger:
|
||||
|
||||
```bash
|
||||
actual="$(git rev-parse --git-path v2r1-active-runtime-imports.actual)"
|
||||
git add active-runtime/pyproject.toml active-runtime/app/aios_v2r1/__init__.py \
|
||||
active-runtime/app/aios_v2r1/ingress_service.py active-runtime/app/aios_v2r1/cli.py \
|
||||
tests/v2r1/test_ingress_service.py tests/test_v2r1_package_identity.py \
|
||||
active-runtime/app/aios_v2r1/message_ledger.py active-runtime/app/aios_v2r1/memory_scope.py \
|
||||
active-runtime/app/aios_v2r1/secret_scope.py active-runtime/app/aios_v2r1/audit.py \
|
||||
active-runtime/app/aios_v2r1/hermes_profile.py active-runtime/app/aios_v2r1/cell_manager.py \
|
||||
active-runtime/app/aios_v2r1/hermes_fabric.py tests/v2r1/test_message_ledger_append.py \
|
||||
tests/v2r1/test_memory_scope.py tests/v2r1/test_secret_scope.py tests/v2r1/test_audit.py \
|
||||
tests/v2r1/test_hermes_profile.py tests/v2r1/test_cell_manager.py tests/v2r1/test_hermes_fabric.py
|
||||
tests/v2r1/test_ingress_service.py tests/test_v2r1_package_identity.py
|
||||
while IFS= read -r path; do git add -- "$path"; done <"$actual"
|
||||
git commit -m "feat(v2r1): package canonical authenticated ingress"
|
||||
```
|
||||
|
||||
### Review B2
|
||||
|
||||
- [ ] Require `git diff --check`, exactly 43 paths (the original 29 plus the exact 14 matrix paths), exact-list/no-shim checks, focused matrix/carried tests, full collect/full pytest, Node 15, real loader default/opt-in, compileall, and wheel identity.
|
||||
- [ ] Require `git diff --check`, exactly 29 paths (six named plus Appendix A), exact-list/no-shim checks, full collect/full pytest, and wheel identity.
|
||||
- [ ] Require B2 parent equals B1 in ledger.
|
||||
- [ ] Prove mutation routes remain fail-closed until authenticated processors are installed.
|
||||
- [ ] Prove every production matrix edit has a recorded pre-edit RED and every already-correct case is recorded as characterization. The partial R9 ledger must contain exactly `START,B1,B2`; B3/B4/B5 remain absent.
|
||||
- [ ] After all prior B2 review checks pass, append B2 and verify the recorded commit identity:
|
||||
|
||||
```bash
|
||||
|
||||
@@ -19,7 +19,6 @@ Alternative C remains the selected architecture because active full-execution au
|
||||
- B3 stops unless the installed Weixin payload shape, patch target hashes, authority-map ownership, and transport signing boundary are evidenced.
|
||||
- B4 stops unless Hermes request/response schema, router ownership, downstream timeout, idempotency behavior, and exact outbound message binding are evidenced.
|
||||
- B5 stops unless B3 and B4 are accepted and the reconciled sentinel plus the V1R4C6 live-runtime snapshot are current for the candidate digest.
|
||||
- The R9 D0 documentation correction becomes ledger `START` without consuming a blocker. It expands B2 executable coverage only; all authenticated transport, evidence, terminal, isolation, and release gates remain unchanged.
|
||||
|
||||
The present outbound evidence is insufficient, so B4 and B5 are currently stopped. This document defines the fail-closed path; it does not claim the missing evidence exists.
|
||||
|
||||
@@ -131,12 +130,6 @@ The release package has one V2R1 import identity: `aios_v2r1`. There is no `acti
|
||||
|
||||
`active-runtime/pyproject.toml` packages `aios_v2r1` from `active-runtime/app`. Repository tests use `PYTHONPATH='active-runtime:active-runtime/app'`: legacy modules import as `app.*`, while V2R1 imports as `aios_v2r1.*`. The implementation plan enumerates all 23 known `active_runtime.app` test imports and replaces them explicitly. Full collection, full pytest, and wheel inspection must prove the wheel contains one V2R1 namespace and that source and installed imports resolve to `aios_v2r1` only.
|
||||
|
||||
Packaging acceptance is also the executable completeness gate for seven preserved runtime components. Message Ledger must prove exact-ID/no-fallback semantics, idempotency/conflict, tenant/cell/direction isolation, expiry/purge/restart/concurrency, and sanitized SQLite errors. Memory must prove every namespace, cross-scope denial, shared-artifact read-only behavior, qualified-key traversal rejection, and disabled search. Secret must prove reference, broker path, scope, kind, version, identifier, no-value-leakage, and fail-closed broker behavior. Audit must prove genesis and tamper/delete/reorder detection, Unicode canonicalization, concurrency, restart, validation, tenant isolation, and sanitized SQLite errors. Hermes Profile must prove exact environment, absolute `0700` roots, traversal/symlink denial, scope, idempotence, and no environment inheritance. Cell Manager/CLI must prove one cell per tenant, an explicit state graph, atomic concurrent persistence, corrupt-registry fail-closed behavior, stable JSON/exit codes, and restart. Fabric must prove that claims return `running` consistently with durable state, isolation, one concurrent claimant, non-claimable states, restart, and sanitized SQLite errors.
|
||||
|
||||
The original 29 B2 paths are extended by exactly fourteen reviewed paths: seven production modules (`message_ledger.py`, `memory_scope.py`, `secret_scope.py`, `audit.py`, `hermes_profile.py`, `cell_manager.py`, and `hermes_fabric.py`) and seven matrix tests (`test_message_ledger_append.py`, `test_memory_scope.py`, `test_secret_scope.py`, `test_audit.py`, `test_hermes_profile.py`, `test_cell_manager.py`, and `test_hermes_fabric.py`). `cli.py` remains one of the original package paths. A production module changes only after its focused test has been observed failing for the intended contract; already-correct behavior is a characterization and must not be weakened merely to manufacture a RED.
|
||||
|
||||
The B2 review requires exactly 43 changed paths, at least 160 passing carried V2R1/integration/package tests with every matrix bullet represented, zero full-collection errors, a passing complete pytest suite, the 15 Node tests, the real isolated loader in default and opt-in modes, compileall, wheel identity, and a clean tree. These coverage additions do not authorize B3 bridge, B4 Hermes HTTP/outbound, B5 deployment, active service, main, tag, `VERSION`, or baseline mutation.
|
||||
|
||||
## Exact projection, quote, and attachment authority
|
||||
|
||||
`WeixinProjection` runs in Python after transport authentication. It preserves numeric Weixin IDs from the JSON token as decimal strings and rejects a value that has already passed through unsafe JavaScript-number conversion.
|
||||
@@ -291,4 +284,4 @@ Preparation or release stops when any of these is true:
|
||||
|
||||
## Acceptance
|
||||
|
||||
The design is review-complete when the plan contains exactly five blocker commits, dynamically anchors their parent chain at B1 start, enumerates all legacy import edits, and has executable RED/GREEN/review gates. R9 preparation additionally requires D0 as `START`, B1 as its child, B2 as one 43-path child commit, the full seven-component executable matrix, and a partial ledger containing exactly `START,B1,B2`. Runtime release acceptance additionally requires all B3/B4/B5 evidence gates, the full Python collection and suite, the real Node/OpenClaw loader harness, exact receipt semantics, isolated candidate staging, deterministic artifacts, current live evidence, and rehearsed constrained rollback.
|
||||
The design is review-complete when the plan contains exactly five blocker commits, dynamically anchors their parent chain at B1 start, enumerates all legacy import edits, and has executable RED/GREEN/review gates. Runtime release acceptance additionally requires all B3/B4/B5 evidence gates, the full Python collection and suite, the real Node/OpenClaw loader harness, exact receipt semantics, isolated candidate staging, deterministic artifacts, current live evidence, and rehearsed constrained rollback.
|
||||
|
||||
@@ -1,101 +0,0 @@
|
||||
"""Executable completeness contract for the append-only audit chain."""
|
||||
from __future__ import annotations
|
||||
from concurrent.futures import ThreadPoolExecutor
|
||||
from pathlib import Path
|
||||
import os
|
||||
import sqlite3
|
||||
import pytest
|
||||
from aios_v2r1.audit import AuditLog
|
||||
from aios_v2r1.tenant_context import ConflictError, ValidationError
|
||||
|
||||
def append(log: AuditLog, index: int = 0, *, tenant_id: str = "tenant-a") -> str:
|
||||
return log.append(tenant_id=tenant_id, trace_id=f"trace-{index}",
|
||||
event_type="tool_call",
|
||||
payload={"index": index, "text": "虾马 café"})
|
||||
|
||||
def test_first_event_is_anchored_to_genesis(tmp_path: Path) -> None:
|
||||
database = tmp_path / "audit.sqlite3"
|
||||
log = AuditLog(database)
|
||||
append(log)
|
||||
with sqlite3.connect(database) as db:
|
||||
assert db.execute("SELECT previous_hash FROM audit_events").fetchone()[0] == "GENESIS"
|
||||
assert log.verify()
|
||||
|
||||
def test_unicode_payload_is_canonical_across_restart(tmp_path: Path) -> None:
|
||||
database = tmp_path / "audit.sqlite3"
|
||||
digest = append(AuditLog(database))
|
||||
reopened = AuditLog(database)
|
||||
assert reopened.verify()
|
||||
with sqlite3.connect(database) as db:
|
||||
stored = db.execute("SELECT event_hash,payload FROM audit_events").fetchone()
|
||||
assert stored[0] == digest
|
||||
assert "虾马" in stored[1]
|
||||
|
||||
def test_payload_tamper_is_detected(tmp_path: Path) -> None:
|
||||
database = tmp_path / "audit.sqlite3"
|
||||
log = AuditLog(database)
|
||||
append(log)
|
||||
with sqlite3.connect(database) as db:
|
||||
db.execute("UPDATE audit_events SET payload='{}'")
|
||||
assert not log.verify()
|
||||
|
||||
def test_middle_event_deletion_is_detected(tmp_path: Path) -> None:
|
||||
database = tmp_path / "audit.sqlite3"
|
||||
log = AuditLog(database)
|
||||
for index in range(3):
|
||||
append(log, index)
|
||||
with sqlite3.connect(database) as db:
|
||||
db.execute("DELETE FROM audit_events WHERE seq=2")
|
||||
assert not log.verify()
|
||||
|
||||
def test_event_reordering_is_detected(tmp_path: Path) -> None:
|
||||
database = tmp_path / "audit.sqlite3"
|
||||
log = AuditLog(database)
|
||||
append(log, 1)
|
||||
append(log, 2)
|
||||
with sqlite3.connect(database) as db:
|
||||
db.execute("UPDATE audit_events SET seq=100 WHERE seq=1")
|
||||
assert not log.verify()
|
||||
|
||||
def test_concurrent_appends_form_one_valid_chain(tmp_path: Path) -> None:
|
||||
database = tmp_path / "audit.sqlite3"
|
||||
log = AuditLog(database)
|
||||
with ThreadPoolExecutor(max_workers=16) as executor:
|
||||
digests = list(executor.map(lambda index: append(log, index), range(24)))
|
||||
assert len(set(digests)) == 24
|
||||
assert log.verify()
|
||||
with sqlite3.connect(database) as db:
|
||||
assert db.execute("SELECT count(*) FROM audit_events").fetchone()[0] == 24
|
||||
|
||||
@pytest.mark.parametrize("kwargs", [
|
||||
{"tenant_id": "Tenant-A"}, {"trace_id": "../trace"},
|
||||
{"event_type": "tool/call"}])
|
||||
def test_audit_identifiers_are_validated(tmp_path: Path, kwargs: dict[str, str]) -> None:
|
||||
values = {"tenant_id": "tenant-a", "trace_id": "trace-a",
|
||||
"event_type": "tool_call", "payload": {"ok": True}}
|
||||
values.update(kwargs)
|
||||
with pytest.raises(ValidationError):
|
||||
AuditLog(tmp_path / "audit.sqlite3").append(**values)
|
||||
|
||||
def test_tenants_share_no_hash_identity_for_equal_payloads(tmp_path: Path) -> None:
|
||||
log = AuditLog(tmp_path / "audit.sqlite3")
|
||||
first = append(log, tenant_id="tenant-a")
|
||||
second = append(log, tenant_id="tenant-b")
|
||||
assert first != second
|
||||
assert log.verify()
|
||||
|
||||
def test_database_is_owner_only(tmp_path: Path) -> None:
|
||||
database = tmp_path / "audit.sqlite3"
|
||||
AuditLog(database)
|
||||
assert os.stat(database).st_mode & 0o777 == 0o600
|
||||
|
||||
def test_sqlite_failures_are_sanitized(tmp_path: Path) -> None:
|
||||
database = tmp_path / "audit.sqlite3"
|
||||
log = AuditLog(database)
|
||||
database.write_bytes(b"not-a-sqlite-database")
|
||||
with pytest.raises(ConflictError, match="audit storage unavailable") as raised:
|
||||
log.verify()
|
||||
assert not isinstance(raised.value, sqlite3.Error)
|
||||
assert "sqlite" not in str(raised.value).lower()
|
||||
assert raised.value.__cause__ is None
|
||||
assert raised.value.__context__ is None
|
||||
@@ -1,114 +0,0 @@
|
||||
"""Executable completeness contract for CellManager and its CLI."""
|
||||
from __future__ import annotations
|
||||
from concurrent.futures import ThreadPoolExecutor
|
||||
import json
|
||||
import os
|
||||
from pathlib import Path
|
||||
from unittest.mock import patch
|
||||
import pytest
|
||||
from aios_v2r1.cell_manager import CellManager
|
||||
from aios_v2r1.cli import main
|
||||
from aios_v2r1.tenant_context import ValidationError
|
||||
|
||||
def test_one_cell_per_tenant(tmp_path: Path) -> None:
|
||||
manager = CellManager(tmp_path / "cells.json")
|
||||
manager.create("tenant-a", "cell-a", "v1", "digest-a")
|
||||
with pytest.raises(ValidationError, match="already"):
|
||||
manager.create("tenant-a", "cell-b", "v1", "digest-b")
|
||||
|
||||
def test_explicit_state_graph_accepts_the_recovery_cycle(tmp_path: Path) -> None:
|
||||
manager = CellManager(tmp_path / "cells.json")
|
||||
manager.create("tenant-a", "cell-a", "v1", "digest-a")
|
||||
for state in ("starting", "healthy", "upgrading", "rollback", "healthy"):
|
||||
assert manager.transition("tenant-a", state).state == state
|
||||
|
||||
def test_explicit_state_graph_rejects_jump_from_created_to_healthy(tmp_path: Path) -> None:
|
||||
manager = CellManager(tmp_path / "cells.json")
|
||||
manager.create("tenant-a", "cell-a", "v1", "digest-a")
|
||||
with pytest.raises(ValidationError, match="transition"):
|
||||
manager.transition("tenant-a", "healthy")
|
||||
|
||||
def test_persistence_uses_atomic_replace(tmp_path: Path) -> None:
|
||||
manager = CellManager(tmp_path / "cells.json")
|
||||
with patch("aios_v2r1.cell_manager.os.replace", wraps=os.replace) as replaced:
|
||||
manager.create("tenant-a", "cell-a", "v1", "digest-a")
|
||||
assert replaced.called
|
||||
|
||||
def test_concurrent_distinct_tenant_creates_are_not_lost(tmp_path: Path) -> None:
|
||||
registry = tmp_path / "cells.json"
|
||||
manager = CellManager(registry)
|
||||
def create(index: int) -> None:
|
||||
manager.create(f"tenant-{index}", f"cell-{index}", "v1", f"digest-{index}")
|
||||
with ThreadPoolExecutor(max_workers=16) as executor:
|
||||
list(executor.map(create, range(24)))
|
||||
data = json.loads(registry.read_text(encoding="utf-8"))
|
||||
assert len(data["cells"]) == 24
|
||||
|
||||
def test_concurrent_same_tenant_has_exactly_one_winner(tmp_path: Path) -> None:
|
||||
manager = CellManager(tmp_path / "cells.json")
|
||||
def create(index: int) -> str:
|
||||
try:
|
||||
manager.create("tenant-a", f"cell-{index}", "v1", f"digest-{index}")
|
||||
return "created"
|
||||
except ValidationError:
|
||||
return "rejected"
|
||||
with ThreadPoolExecutor(max_workers=16) as executor:
|
||||
results = list(executor.map(create, range(16)))
|
||||
assert results.count("created") == 1
|
||||
assert results.count("rejected") == 15
|
||||
|
||||
def test_corrupt_registry_fails_closed_with_domain_error(tmp_path: Path) -> None:
|
||||
registry = tmp_path / "cells.json"
|
||||
manager = CellManager(registry)
|
||||
registry.write_text('{"cells":{"tenant-a":', encoding="utf-8")
|
||||
with pytest.raises(ValidationError, match="registry unavailable") as raised:
|
||||
manager.status("tenant-a")
|
||||
assert "JSON" not in type(raised.value).__name__
|
||||
assert raised.value.__cause__ is None
|
||||
assert raised.value.__context__ is None
|
||||
|
||||
def test_restart_preserves_cell_status(tmp_path: Path) -> None:
|
||||
registry = tmp_path / "cells.json"
|
||||
CellManager(registry).create("tenant-a", "cell-a", "v1", "digest-a")
|
||||
assert CellManager(registry).status("tenant-a").cell_id == "cell-a"
|
||||
|
||||
def test_cli_create_returns_stable_json(
|
||||
tmp_path: Path, capsys: pytest.CaptureFixture[str]
|
||||
) -> None:
|
||||
registry = tmp_path / "cells.json"
|
||||
assert main([str(registry), "create", "tenant-a", "cell-a", "v1", "digest-a"]) == 0
|
||||
output = json.loads(capsys.readouterr().out)
|
||||
assert output["tenant_id"] == "tenant-a"
|
||||
assert output["state"] == "created"
|
||||
|
||||
def test_cli_domain_failure_returns_code_3_and_json(
|
||||
tmp_path: Path, capsys: pytest.CaptureFixture[str]
|
||||
) -> None:
|
||||
registry = tmp_path / "cells.json"
|
||||
assert main([str(registry), "status", "missing-tenant"]) == 3
|
||||
captured = capsys.readouterr()
|
||||
assert captured.out == ""
|
||||
assert json.loads(captured.err) == {
|
||||
"code": "VALIDATION_ERROR", "error": "unknown tenant"}
|
||||
|
||||
def test_cli_corrupt_registry_is_sanitized(
|
||||
tmp_path: Path, capsys: pytest.CaptureFixture[str]
|
||||
) -> None:
|
||||
registry = tmp_path / "cells.json"
|
||||
CellManager(registry)
|
||||
registry.write_text("TOP-SECRET invalid json", encoding="utf-8")
|
||||
assert main([str(registry), "status", "tenant-a"]) == 3
|
||||
error = json.loads(capsys.readouterr().err)
|
||||
assert error["code"] == "VALIDATION_ERROR"
|
||||
assert "TOP-SECRET" not in error["error"]
|
||||
|
||||
@pytest.mark.parametrize("args", [
|
||||
("Tenant-A", "cell-a", "v1", "digest-a"),
|
||||
("tenant-a", "../cell", "v1", "digest-a"),
|
||||
("tenant-a", "cell-a", "../v1", "digest-a"),
|
||||
("tenant-a", "cell-a", "v1", "../digest")])
|
||||
def test_create_validates_all_identifiers(
|
||||
tmp_path: Path, args: tuple[str, str, str, str]
|
||||
) -> None:
|
||||
with pytest.raises(ValidationError):
|
||||
CellManager(tmp_path / "cells.json").create(*args)
|
||||
@@ -1,114 +1,88 @@
|
||||
"""Executable completeness contract for the tenant-partitioned Hermes fabric."""
|
||||
"""Gate 1 contract tests for the Hermes shared agent fabric."""
|
||||
from __future__ import annotations
|
||||
from concurrent.futures import ThreadPoolExecutor
|
||||
from dataclasses import replace
|
||||
from pathlib import Path
|
||||
|
||||
import sqlite3
|
||||
import pytest
|
||||
from tempfile import TemporaryDirectory
|
||||
import unittest
|
||||
|
||||
from aios_v2r1.hermes_fabric import HermesFabric
|
||||
from aios_v2r1.tenant_context import CanonicalMessage, ConflictError, ScopeError
|
||||
|
||||
def authenticated_command(event_id: str, **changes: object) -> CanonicalMessage:
|
||||
value = CanonicalMessage(
|
||||
tenant_id="tenant-a", cell_id="cell-a", principal_id="user-a",
|
||||
principal_type="authenticated_user", origin_type="channel_user",
|
||||
channel="weixin", channel_account_id="account-a", peer_id="peer-a",
|
||||
conversation_id="conversation-a", session_id="session-a", task_id=None,
|
||||
event_id=event_id, message_id=f"message-{event_id}",
|
||||
reply_to_message_id=None, direction="inbound", command_capable=True,
|
||||
|
||||
def authenticated_command(
|
||||
event_id: str,
|
||||
*,
|
||||
command_capable: bool = True,
|
||||
origin_type: str = "channel_user",
|
||||
) -> CanonicalMessage:
|
||||
return CanonicalMessage(
|
||||
tenant_id="tenant-a",
|
||||
cell_id="cell-a",
|
||||
principal_id="user-a",
|
||||
principal_type="authenticated_user",
|
||||
origin_type=origin_type,
|
||||
channel="weixin",
|
||||
channel_account_id="account-a",
|
||||
peer_id="peer-a",
|
||||
conversation_id="conversation-a",
|
||||
session_id="session-a",
|
||||
task_id=None,
|
||||
event_id=event_id,
|
||||
message_id="1234567890123456789",
|
||||
reply_to_message_id=None,
|
||||
direction="inbound",
|
||||
command_capable=command_capable,
|
||||
occurred_at="2026-07-13T00:00:00+00:00",
|
||||
received_at="2026-07-13T00:00:01+00:00", body="/run",
|
||||
quoted_body=None, adapter_name="weixin", adapter_version="v2")
|
||||
return replace(value, **changes)
|
||||
received_at="2026-07-13T00:00:01+00:00",
|
||||
body="/run",
|
||||
quoted_body=None,
|
||||
adapter_name="weixin",
|
||||
adapter_version="v2",
|
||||
)
|
||||
|
||||
@pytest.fixture
|
||||
def fabric(tmp_path: Path) -> HermesFabric:
|
||||
return HermesFabric(tmp_path / "fabric.sqlite3")
|
||||
|
||||
def test_duplicate_event_returns_sanitized_conflict(fabric: HermesFabric) -> None:
|
||||
command = authenticated_command("event-a")
|
||||
assert fabric.enqueue(message=command, profile_id="profile-a").event_id == "event-a"
|
||||
with pytest.raises(ConflictError) as raised:
|
||||
fabric.enqueue(message=command, profile_id="profile-a")
|
||||
assert not isinstance(raised.value, sqlite3.IntegrityError)
|
||||
assert "sqlite" not in str(raised.value).lower()
|
||||
assert raised.value.__cause__ is None
|
||||
assert raised.value.__context__ is None
|
||||
class HermesFabricContractTests(unittest.TestCase):
|
||||
def test_duplicate_event_returns_sanitized_conflict(self) -> None:
|
||||
with TemporaryDirectory() as directory:
|
||||
fabric = HermesFabric(f"{directory}/fabric.sqlite3")
|
||||
message = authenticated_command("event-a")
|
||||
|
||||
@pytest.mark.parametrize("changes", [
|
||||
{"command_capable": False}, {"origin_type": "heartbeat"},
|
||||
{"principal_type": "service"}, {"direction": "internal"}])
|
||||
def test_non_claimable_provenance_cannot_enqueue(
|
||||
fabric: HermesFabric, changes: dict[str, object]
|
||||
) -> None:
|
||||
with pytest.raises(ScopeError):
|
||||
fabric.enqueue(message=authenticated_command("event-denied", **changes),
|
||||
profile_id="profile-a")
|
||||
first = fabric.enqueue(message=message, profile_id="profile-a")
|
||||
self.assertEqual(first.event_id, "event-a")
|
||||
|
||||
def test_claim_returns_running_and_matches_durable_state(fabric: HermesFabric) -> None:
|
||||
fabric.enqueue(message=authenticated_command("event-a"), profile_id="profile-a")
|
||||
claimed = fabric.claim("tenant-a", "cell-a", "profile-a")
|
||||
assert claimed is not None
|
||||
assert claimed.status == "running"
|
||||
with sqlite3.connect(fabric.database) as db:
|
||||
assert db.execute("SELECT status FROM fabric_jobs WHERE job_id=?",
|
||||
(claimed.job_id,)).fetchone()[0] == "running"
|
||||
with self.assertRaises(ConflictError) as raised:
|
||||
fabric.enqueue(message=message, profile_id="profile-a")
|
||||
|
||||
@pytest.mark.parametrize(("tenant_id", "cell_id", "profile_id"), [
|
||||
("tenant-b", "cell-a", "profile-a"), ("tenant-a", "cell-b", "profile-a"),
|
||||
("tenant-a", "cell-a", "profile-b")])
|
||||
def test_claim_scope_is_exact(
|
||||
fabric: HermesFabric, tenant_id: str, cell_id: str, profile_id: str
|
||||
) -> None:
|
||||
fabric.enqueue(message=authenticated_command("event-a"), profile_id="profile-a")
|
||||
assert fabric.claim(tenant_id, cell_id, profile_id) is None
|
||||
assert fabric.claim("tenant-a", "cell-a", "profile-a") is not None
|
||||
error = raised.exception
|
||||
self.assertNotIsInstance(error, sqlite3.IntegrityError)
|
||||
self.assertNotIn("sqlite", str(error).lower())
|
||||
self.assertIsNone(error.__cause__)
|
||||
self.assertIsNone(error.__context__)
|
||||
|
||||
def test_only_one_concurrent_claimant_wins(fabric: HermesFabric) -> None:
|
||||
fabric.enqueue(message=authenticated_command("event-a"), profile_id="profile-a")
|
||||
with ThreadPoolExecutor(max_workers=16) as executor:
|
||||
claimed = list(executor.map(
|
||||
lambda _: fabric.claim("tenant-a", "cell-a", "profile-a"), range(16)))
|
||||
winners = [job for job in claimed if job is not None]
|
||||
assert len(winners) == 1
|
||||
assert winners[0].status == "running"
|
||||
def test_non_command_event_cannot_enqueue(self) -> None:
|
||||
with TemporaryDirectory() as directory:
|
||||
fabric = HermesFabric(f"{directory}/fabric.sqlite3")
|
||||
|
||||
@pytest.mark.parametrize("status", ["running", "completed", "failed", "cancelled"])
|
||||
def test_nonqueued_states_are_not_claimable(
|
||||
fabric: HermesFabric, status: str
|
||||
) -> None:
|
||||
job = fabric.enqueue(message=authenticated_command("event-a"), profile_id="profile-a")
|
||||
with sqlite3.connect(fabric.database) as db:
|
||||
db.execute("UPDATE fabric_jobs SET status=? WHERE job_id=?", (status, job.job_id))
|
||||
assert fabric.claim("tenant-a", "cell-a", "profile-a") is None
|
||||
with self.assertRaises(ScopeError):
|
||||
fabric.enqueue(
|
||||
message=authenticated_command(
|
||||
"event-non-command", command_capable=False
|
||||
),
|
||||
profile_id="profile-a",
|
||||
)
|
||||
|
||||
def test_restart_preserves_queue_and_claims_once(tmp_path: Path) -> None:
|
||||
database = tmp_path / "fabric.sqlite3"
|
||||
HermesFabric(database).enqueue(message=authenticated_command("event-a"),
|
||||
profile_id="profile-a")
|
||||
reopened = HermesFabric(database)
|
||||
claimed = reopened.claim("tenant-a", "cell-a", "profile-a")
|
||||
assert claimed is not None and claimed.status == "running"
|
||||
assert reopened.claim("tenant-a", "cell-a", "profile-a") is None
|
||||
def test_heartbeat_provenance_cannot_enqueue(self) -> None:
|
||||
with TemporaryDirectory() as directory:
|
||||
fabric = HermesFabric(f"{directory}/fabric.sqlite3")
|
||||
|
||||
def test_concurrent_duplicate_enqueue_has_one_winner(fabric: HermesFabric) -> None:
|
||||
command = authenticated_command("event-a")
|
||||
def enqueue(_: int) -> str:
|
||||
try:
|
||||
fabric.enqueue(message=command, profile_id="profile-a")
|
||||
return "queued"
|
||||
except ConflictError:
|
||||
return "conflict"
|
||||
with ThreadPoolExecutor(max_workers=16) as executor:
|
||||
results = list(executor.map(enqueue, range(16)))
|
||||
assert results.count("queued") == 1
|
||||
assert results.count("conflict") == 15
|
||||
with self.assertRaises(ScopeError):
|
||||
fabric.enqueue(
|
||||
message=authenticated_command(
|
||||
"event-heartbeat", origin_type="heartbeat"
|
||||
),
|
||||
profile_id="profile-a",
|
||||
)
|
||||
|
||||
def test_sqlite_failures_are_sanitized(fabric: HermesFabric) -> None:
|
||||
Path(fabric.database).write_bytes(b"not-a-sqlite-database")
|
||||
with pytest.raises(ConflictError, match="fabric storage unavailable") as raised:
|
||||
fabric.health()
|
||||
assert not isinstance(raised.value, sqlite3.Error)
|
||||
assert "sqlite" not in str(raised.value).lower()
|
||||
assert raised.value.__cause__ is None
|
||||
assert raised.value.__context__ is None
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
|
||||
@@ -1,88 +0,0 @@
|
||||
"""Executable completeness contract for Hermes profile isolation."""
|
||||
from __future__ import annotations
|
||||
from pathlib import Path
|
||||
import os
|
||||
import pytest
|
||||
from aios_v2r1.hermes_profile import HermesProfile
|
||||
from aios_v2r1.tenant_context import ValidationError
|
||||
|
||||
def profile(tmp_path: Path, **changes: object) -> HermesProfile:
|
||||
values: dict[str, object] = {
|
||||
"tenant_id": "tenant-a", "cell_id": "cell-a", "profile_id": "profile-a",
|
||||
"hermes_home": tmp_path / "home", "workspace": tmp_path / "workspace"}
|
||||
values.update(changes)
|
||||
return HermesProfile(**values) # type: ignore[arg-type]
|
||||
|
||||
def test_environment_is_exact_and_has_no_inherited_values(
|
||||
tmp_path: Path, monkeypatch: pytest.MonkeyPatch
|
||||
) -> None:
|
||||
monkeypatch.setenv("HOST_SECRET", "must-not-inherit")
|
||||
value = profile(tmp_path).environment
|
||||
assert value == {
|
||||
"HERMES_HOME": str(tmp_path / "home"), "HOME": str(tmp_path / "home"),
|
||||
"AIOS_TENANT_ID": "tenant-a", "AIOS_CELL_ID": "cell-a",
|
||||
"AIOS_PROFILE_ID": "profile-a"}
|
||||
assert "HOST_SECRET" not in value
|
||||
|
||||
@pytest.mark.parametrize("changes", [
|
||||
{"hermes_home": Path("relative-home")},
|
||||
{"workspace": Path("relative-workspace")}])
|
||||
def test_profile_roots_must_be_absolute(
|
||||
tmp_path: Path, changes: dict[str, Path]
|
||||
) -> None:
|
||||
with pytest.raises(ValidationError, match="absolute"):
|
||||
profile(tmp_path, **changes)
|
||||
|
||||
def test_prepare_sets_both_roots_to_0700(tmp_path: Path) -> None:
|
||||
value = profile(tmp_path)
|
||||
value.prepare()
|
||||
assert os.stat(value.hermes_home).st_mode & 0o777 == 0o700
|
||||
assert os.stat(value.workspace).st_mode & 0o777 == 0o700
|
||||
|
||||
def test_prepare_is_idempotent(tmp_path: Path) -> None:
|
||||
value = profile(tmp_path)
|
||||
value.prepare()
|
||||
marker = value.workspace / "marker"
|
||||
marker.write_text("kept", encoding="utf-8")
|
||||
value.prepare()
|
||||
assert marker.read_text(encoding="utf-8") == "kept"
|
||||
|
||||
def test_parent_traversal_is_denied(tmp_path: Path) -> None:
|
||||
value = profile(tmp_path)
|
||||
value.prepare()
|
||||
with pytest.raises(ValidationError, match="escapes"):
|
||||
value.assert_path_allowed(value.workspace / ".." / "outside")
|
||||
|
||||
def test_symlink_inside_profile_cannot_escape(tmp_path: Path) -> None:
|
||||
value = profile(tmp_path)
|
||||
value.prepare()
|
||||
outside = tmp_path / "outside"
|
||||
outside.mkdir()
|
||||
(value.workspace / "link").symlink_to(outside, target_is_directory=True)
|
||||
with pytest.raises(ValidationError, match="escapes"):
|
||||
value.assert_path_allowed(value.workspace / "link" / "secret")
|
||||
|
||||
@pytest.mark.parametrize("root_name", ["home", "workspace"])
|
||||
def test_prepare_rejects_symlink_roots(tmp_path: Path, root_name: str) -> None:
|
||||
outside = tmp_path / f"outside-{root_name}"
|
||||
outside.mkdir()
|
||||
symlink = tmp_path / root_name
|
||||
symlink.symlink_to(outside, target_is_directory=True)
|
||||
changes = {"hermes_home" if root_name == "home" else "workspace": symlink}
|
||||
with pytest.raises(ValidationError, match="symlink"):
|
||||
profile(tmp_path, **changes).prepare()
|
||||
|
||||
def test_other_profile_scope_is_denied(tmp_path: Path) -> None:
|
||||
first = profile(tmp_path / "first")
|
||||
second = profile(tmp_path / "second", tenant_id="tenant-b",
|
||||
cell_id="cell-b", profile_id="profile-b")
|
||||
first.prepare()
|
||||
second.prepare()
|
||||
with pytest.raises(ValidationError, match="escapes"):
|
||||
first.assert_path_allowed(second.workspace / "data")
|
||||
|
||||
def test_paths_within_either_root_are_allowed(tmp_path: Path) -> None:
|
||||
value = profile(tmp_path)
|
||||
value.prepare()
|
||||
value.assert_path_allowed(value.hermes_home / "config.json")
|
||||
value.assert_path_allowed(value.workspace / "task.txt")
|
||||
@@ -8,7 +8,6 @@ import socket
|
||||
import subprocess
|
||||
import sys
|
||||
import threading
|
||||
import textwrap
|
||||
import time
|
||||
from collections.abc import Callable
|
||||
from contextlib import contextmanager
|
||||
@@ -373,8 +372,8 @@ def test_server_close_drains_partial_body_handler_and_prevents_late_processor(
|
||||
assert "Traceback" not in captured.out
|
||||
assert "Traceback" not in captured.err
|
||||
assert "Fatal Python error" not in captured.err
|
||||
restarted = build_server(str(host), int(port))
|
||||
restarted.server_close()
|
||||
with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as rebound:
|
||||
rebound.bind((str(host), int(port)))
|
||||
|
||||
|
||||
@pytest.mark.parametrize(
|
||||
@@ -788,245 +787,6 @@ def test_af_inet_server_rejects_ipv6_loopback_explicitly() -> None:
|
||||
build_server("::1", 0)
|
||||
|
||||
|
||||
|
||||
def run_pre_header_sigint_probe(
|
||||
timeout: float = 1.2,
|
||||
) -> tuple[int, str, str, float, bool, int]:
|
||||
with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as reservation:
|
||||
reservation.bind(("127.0.0.1", 0))
|
||||
port = int(reservation.getsockname()[1])
|
||||
|
||||
script = textwrap.dedent(
|
||||
"""
|
||||
import os
|
||||
import signal
|
||||
import socket
|
||||
import sys
|
||||
import threading
|
||||
import time
|
||||
|
||||
from aios_v2r1.ingress_service import (
|
||||
IngressHTTPServer,
|
||||
IngressRequestHandler,
|
||||
)
|
||||
|
||||
accepted_before_setup = threading.Event()
|
||||
|
||||
class PreHeaderReadinessHandler(IngressRequestHandler):
|
||||
def setup(self):
|
||||
accepted_before_setup.set()
|
||||
try:
|
||||
self.request.recv(1)
|
||||
except OSError:
|
||||
pass
|
||||
super().setup()
|
||||
|
||||
server = IngressHTTPServer(
|
||||
("127.0.0.1", int(sys.argv[1])),
|
||||
PreHeaderReadinessHandler,
|
||||
None,
|
||||
)
|
||||
|
||||
def connect_and_interrupt():
|
||||
client = socket.create_connection(server.server_address, timeout=2)
|
||||
if not accepted_before_setup.wait(timeout=2):
|
||||
os._exit(71)
|
||||
os.kill(os.getpid(), signal.SIGINT)
|
||||
time.sleep(10)
|
||||
client.close()
|
||||
|
||||
trigger = threading.Thread(target=connect_and_interrupt, daemon=True)
|
||||
trigger.start()
|
||||
try:
|
||||
server.serve_forever(poll_interval=0.01)
|
||||
except KeyboardInterrupt:
|
||||
pass
|
||||
finally:
|
||||
server.server_close()
|
||||
"""
|
||||
)
|
||||
env = os.environ.copy()
|
||||
package_root = str(Path(__file__).resolve().parents[2] / "active-runtime" / "app")
|
||||
env["PYTHONPATH"] = package_root + os.pathsep + env.get("PYTHONPATH", "")
|
||||
process = subprocess.Popen(
|
||||
[sys.executable, "-c", script, str(port)],
|
||||
env=env,
|
||||
stdout=subprocess.PIPE,
|
||||
stderr=subprocess.PIPE,
|
||||
text=True,
|
||||
)
|
||||
started = time.monotonic()
|
||||
timed_out = False
|
||||
try:
|
||||
stdout, stderr = process.communicate(timeout=timeout)
|
||||
except subprocess.TimeoutExpired:
|
||||
timed_out = True
|
||||
process.kill()
|
||||
stdout, stderr = process.communicate(timeout=2)
|
||||
return (
|
||||
int(process.returncode),
|
||||
stdout,
|
||||
stderr,
|
||||
time.monotonic() - started,
|
||||
timed_out,
|
||||
port,
|
||||
)
|
||||
|
||||
|
||||
def test_sigint_closes_pre_header_readiness_socket_in_25_bounded_runs() -> None:
|
||||
for iteration in range(25):
|
||||
returncode, stdout, stderr, elapsed, timed_out, port = (
|
||||
run_pre_header_sigint_probe()
|
||||
)
|
||||
assert not timed_out, f"pre-header SIGINT hung on iteration {iteration}"
|
||||
assert elapsed < 1.2
|
||||
assert returncode == 0
|
||||
assert "Traceback" not in stdout
|
||||
assert "Traceback" not in stderr
|
||||
assert "Fatal Python error" not in stderr
|
||||
restarted = build_server("127.0.0.1", port)
|
||||
restarted.server_close()
|
||||
|
||||
|
||||
def test_server_close_closes_socket_accepted_before_handler_setup() -> None:
|
||||
server = build_server("127.0.0.1", 0)
|
||||
client = socket.create_connection(server.server_address, timeout=2)
|
||||
accepted, _ = server.get_request()
|
||||
client.settimeout(0.4)
|
||||
try:
|
||||
server.server_close()
|
||||
server.server_close()
|
||||
try:
|
||||
remaining = client.recv(1)
|
||||
except ConnectionResetError:
|
||||
remaining = b""
|
||||
assert remaining == b""
|
||||
finally:
|
||||
accepted.close()
|
||||
client.close()
|
||||
server.server_close()
|
||||
|
||||
|
||||
def test_process_request_rejects_socket_after_server_closing() -> None:
|
||||
handler_started = threading.Event()
|
||||
|
||||
class RecordingHandler:
|
||||
def __init__(self, *args: object) -> None:
|
||||
handler_started.set()
|
||||
|
||||
server = IngressHTTPServer(
|
||||
("127.0.0.1", 0),
|
||||
RecordingHandler, # type: ignore[arg-type]
|
||||
None,
|
||||
)
|
||||
server.server_close()
|
||||
request_socket, peer = socket.socketpair()
|
||||
peer.settimeout(0.4)
|
||||
try:
|
||||
server.process_request(request_socket, ("127.0.0.1", 1))
|
||||
try:
|
||||
remaining = peer.recv(1)
|
||||
except ConnectionResetError:
|
||||
remaining = b""
|
||||
assert remaining == b""
|
||||
assert not handler_started.wait(timeout=0.1)
|
||||
finally:
|
||||
request_socket.close()
|
||||
peer.close()
|
||||
server.server_close()
|
||||
|
||||
|
||||
|
||||
def test_accept_and_server_close_race_is_bounded_in_25_runs() -> None:
|
||||
errors: list[BaseException] = []
|
||||
for _ in range(25):
|
||||
class RecordingHandler:
|
||||
def __init__(self, *args: object) -> None:
|
||||
return
|
||||
|
||||
server = IngressHTTPServer(
|
||||
("127.0.0.1", 0),
|
||||
RecordingHandler, # type: ignore[arg-type]
|
||||
None,
|
||||
)
|
||||
client = socket.create_connection(server.server_address, timeout=2)
|
||||
barrier = threading.Barrier(3)
|
||||
|
||||
def accept_and_process() -> None:
|
||||
try:
|
||||
barrier.wait(timeout=1)
|
||||
request_socket, client_address = server.get_request()
|
||||
server.process_request(request_socket, client_address)
|
||||
except OSError:
|
||||
return
|
||||
except BaseException as exc:
|
||||
errors.append(exc)
|
||||
|
||||
def close_during_accept() -> None:
|
||||
try:
|
||||
barrier.wait(timeout=1)
|
||||
server.server_close()
|
||||
except BaseException as exc:
|
||||
errors.append(exc)
|
||||
|
||||
accepter = threading.Thread(target=accept_and_process)
|
||||
closer = threading.Thread(target=close_during_accept)
|
||||
accepter.start()
|
||||
closer.start()
|
||||
barrier.wait(timeout=1)
|
||||
accepter.join(timeout=1)
|
||||
closer.join(timeout=1)
|
||||
client.close()
|
||||
server.server_close()
|
||||
assert not accepter.is_alive()
|
||||
assert not closer.is_alive()
|
||||
assert not errors
|
||||
|
||||
def test_server_close_is_idempotent_with_idle_and_partial_clients(
|
||||
capsys: pytest.CaptureFixture[str],
|
||||
) -> None:
|
||||
server = build_server("127.0.0.1", 0)
|
||||
server_thread = threading.Thread(target=server.serve_forever, daemon=True)
|
||||
server_thread.start()
|
||||
clients: list[socket.socket] = []
|
||||
payloads = [
|
||||
None,
|
||||
None,
|
||||
b"GET /health/live HTTP/1.1\r\nHost: localhost\r\n",
|
||||
b"POST /v1/ingress HTTP/1.1\r\nContent-Length: 10\r\n\r\nx",
|
||||
]
|
||||
for payload in payloads:
|
||||
client = socket.create_connection(server.server_address, timeout=2)
|
||||
if payload is not None:
|
||||
client.sendall(payload)
|
||||
clients.append(client)
|
||||
time.sleep(0.05)
|
||||
server.shutdown()
|
||||
|
||||
errors: list[BaseException] = []
|
||||
|
||||
def close_server() -> None:
|
||||
try:
|
||||
server.server_close()
|
||||
except BaseException as exc:
|
||||
errors.append(exc)
|
||||
|
||||
closers = [threading.Thread(target=close_server) for _ in range(4)]
|
||||
for closer in closers:
|
||||
closer.start()
|
||||
for closer in closers:
|
||||
closer.join(timeout=2)
|
||||
server_thread.join(timeout=2)
|
||||
for client in clients:
|
||||
client.close()
|
||||
captured = capsys.readouterr()
|
||||
assert not errors
|
||||
assert not [closer for closer in closers if closer.is_alive()]
|
||||
assert not server_thread.is_alive()
|
||||
assert "Traceback" not in captured.out
|
||||
assert "Traceback" not in captured.err
|
||||
assert "Fatal Python error" not in captured.err
|
||||
|
||||
def test_sigint_shutdown_exits_zero_without_traceback_and_releases_port() -> None:
|
||||
with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as reservation:
|
||||
reservation.bind(("127.0.0.1", 0))
|
||||
|
||||
@@ -1,53 +0,0 @@
|
||||
"""Executable completeness contract for memory namespaces and access."""
|
||||
from __future__ import annotations
|
||||
import pytest
|
||||
from aios_v2r1.memory_scope import MemoryScope, qualify_memory_key
|
||||
from aios_v2r1.tenant_context import ScopeError, ValidationError
|
||||
|
||||
def scope(kind: str = "session", **changes: object) -> MemoryScope:
|
||||
values: dict[str, object] = {
|
||||
"tenant_id": "tenant-a", "cell_id": "cell-a", "profile_id": "profile-a",
|
||||
"session_id": "session-a", "kind": kind}
|
||||
values.update(changes)
|
||||
return MemoryScope(**values) # type: ignore[arg-type]
|
||||
|
||||
@pytest.mark.parametrize(("kind", "session_id", "expected"), [
|
||||
("session", "session-a", "tenant/tenant-a/cell/cell-a/profile/profile-a/session/session-a/memory/session"),
|
||||
("profile", None, "tenant/tenant-a/cell/cell-a/profile/profile-a/memory/profile"),
|
||||
("cell", None, "tenant/tenant-a/cell/cell-a/memory/cell"),
|
||||
("tenant", None, "tenant/tenant-a/cell/cell-a/memory/tenant"),
|
||||
("shared_artifact", None, "tenant/tenant-a/cell/cell-a/memory/shared_artifact")])
|
||||
def test_every_namespace_is_explicit(kind: str, session_id: str | None, expected: str) -> None:
|
||||
assert scope(kind, session_id=session_id).namespace == expected
|
||||
|
||||
@pytest.mark.parametrize("requested", [
|
||||
scope(tenant_id="tenant-b"), scope(cell_id="cell-b"),
|
||||
scope(profile_id="profile-b"), scope(session_id="session-b")])
|
||||
def test_cross_scope_access_is_denied(requested: MemoryScope) -> None:
|
||||
with pytest.raises(ScopeError):
|
||||
scope().assert_access(requested)
|
||||
|
||||
def test_cross_kind_access_is_denied() -> None:
|
||||
with pytest.raises(ScopeError, match="cross-kind"):
|
||||
scope("session").assert_access(scope("profile", session_id=None))
|
||||
|
||||
def test_shared_artifacts_are_read_only() -> None:
|
||||
owner = scope()
|
||||
shared = scope("shared_artifact", session_id=None)
|
||||
owner.assert_access(shared)
|
||||
with pytest.raises(ScopeError, match="immutable"):
|
||||
owner.assert_access(shared, write=True)
|
||||
|
||||
def test_qualified_key_contains_the_full_namespace() -> None:
|
||||
assert qualify_memory_key(scope(), "facts.v1") == (
|
||||
"tenant/tenant-a/cell/cell-a/profile/profile-a/session/session-a/"
|
||||
"memory/session/facts.v1")
|
||||
|
||||
@pytest.mark.parametrize("key", ["../escape", "a/b", ".", "..", " space ", "x?query"])
|
||||
def test_memory_key_traversal_and_malformed_keys_are_rejected(key: str) -> None:
|
||||
with pytest.raises(ValidationError):
|
||||
qualify_memory_key(scope(), key)
|
||||
|
||||
def test_memory_search_surface_is_disabled() -> None:
|
||||
assert not hasattr(scope(), "search")
|
||||
assert not hasattr(scope(), "search_all")
|
||||
@@ -1,120 +1,73 @@
|
||||
"""Executable completeness contract for the exact-ID message ledger."""
|
||||
"""Contract tests for the runtime-facing direct MessageLedger append path."""
|
||||
from __future__ import annotations
|
||||
from concurrent.futures import ThreadPoolExecutor
|
||||
from dataclasses import replace
|
||||
from pathlib import Path
|
||||
import sqlite3
|
||||
import pytest
|
||||
from aios_v2r1.message_ledger import MessageLedger
|
||||
from aios_v2r1.tenant_context import CanonicalMessage, ConflictError, ScopeError
|
||||
|
||||
def message(**changes: object) -> CanonicalMessage:
|
||||
value = CanonicalMessage(
|
||||
tenant_id="tenant-a", cell_id="cell-a", principal_id="user-a",
|
||||
from concurrent.futures import ThreadPoolExecutor
|
||||
from tempfile import TemporaryDirectory
|
||||
import unittest
|
||||
|
||||
from aios_v2r1.message_ledger import MessageLedger
|
||||
from aios_v2r1.tenant_context import CanonicalMessage, ConflictError
|
||||
|
||||
|
||||
def message(*, tenant_id: str = "tenant-a", cell_id: str = "cell-a",
|
||||
event_id: str = "event-a", message_id: str = "message-a",
|
||||
body: str = "hello", reply_to_message_id: str | None = None) -> CanonicalMessage:
|
||||
return CanonicalMessage(
|
||||
tenant_id=tenant_id, cell_id=cell_id, principal_id="user-a",
|
||||
principal_type="authenticated_user", origin_type="channel_user",
|
||||
channel="weixin", channel_account_id="account-a", peer_id="peer-a",
|
||||
conversation_id="conversation-a", session_id="session-a", task_id=None,
|
||||
event_id="event-a", message_id="message-a", reply_to_message_id=None,
|
||||
event_id=event_id, message_id=message_id, reply_to_message_id=reply_to_message_id,
|
||||
direction="inbound", command_capable=True,
|
||||
occurred_at="2026-07-13T00:00:00+00:00",
|
||||
received_at="2026-07-13T00:00:01+00:00", body="hello",
|
||||
quoted_body=None, adapter_name="weixin", adapter_version="v2")
|
||||
return replace(value, **changes)
|
||||
received_at="2026-07-13T00:00:01+00:00", body=body,
|
||||
quoted_body=None, adapter_name="weixin", adapter_version="v2",
|
||||
)
|
||||
|
||||
@pytest.fixture
|
||||
def ledger(tmp_path: Path) -> MessageLedger:
|
||||
return MessageLedger(tmp_path / "ledger.sqlite3")
|
||||
|
||||
def test_append_writes_directly_without_using_remember(ledger: MessageLedger) -> None:
|
||||
ledger.remember = lambda _: (_ for _ in ()).throw(AssertionError("remember called")) # type: ignore[method-assign]
|
||||
assert ledger.append(message()).message_id == "message-a"
|
||||
assert ledger.count() == 1
|
||||
class MessageLedgerAppendContractTests(unittest.TestCase):
|
||||
def setUp(self) -> None:
|
||||
self.directory = TemporaryDirectory()
|
||||
self.addCleanup(self.directory.cleanup)
|
||||
self.ledger = MessageLedger(f"{self.directory.name}/ledger.sqlite3")
|
||||
|
||||
def test_append_rejects_same_message_id_with_different_content(ledger: MessageLedger) -> None:
|
||||
ledger.append(message(body="first"))
|
||||
with pytest.raises(ConflictError):
|
||||
ledger.append(message(event_id="event-b", body="second"))
|
||||
assert ledger.count() == 1
|
||||
def test_append_writes_directly_without_using_remember(self) -> None:
|
||||
# A compatibility wrapper may remain, but the runtime append path may not
|
||||
# route through it: this catches append() -> remember() regressions.
|
||||
self.ledger.remember = lambda _: (_ for _ in ()).throw(AssertionError("remember called")) # type: ignore[method-assign]
|
||||
record = self.ledger.append(message())
|
||||
self.assertEqual("message-a", record.message_id)
|
||||
self.assertEqual(1, self.ledger.count())
|
||||
|
||||
def test_append_is_idempotent_when_only_event_id_changes(ledger: MessageLedger) -> None:
|
||||
stored = ledger.append(message(event_id="event-a", body="same body"))
|
||||
replay = ledger.append(message(event_id="event-b", body="same body"))
|
||||
assert replay == stored
|
||||
assert replay.event_id == "event-a"
|
||||
assert ledger.count() == 1
|
||||
def test_append_rejects_same_message_id_with_different_content(self) -> None:
|
||||
self.ledger.append(message(body="first"))
|
||||
with self.assertRaises(ConflictError):
|
||||
self.ledger.append(message(event_id="event-b", body="second"))
|
||||
self.assertEqual(1, self.ledger.count())
|
||||
|
||||
@pytest.mark.parametrize("candidate", ["message", "message-a-extra", "MESSAGE-A"])
|
||||
def test_quote_lookup_has_no_prefix_similarity_or_case_fallback(
|
||||
ledger: MessageLedger, candidate: str
|
||||
) -> None:
|
||||
ledger.append(message(message_id="message-a"))
|
||||
with pytest.raises(ScopeError, match="quoted_text_unavailable"):
|
||||
ledger.resolve_quote(message(event_id="reply-event", message_id="reply-message",
|
||||
reply_to_message_id=candidate))
|
||||
def test_append_is_idempotent_when_only_event_id_changes(self) -> None:
|
||||
stored = self.ledger.append(message(event_id="event-a", body="same body"))
|
||||
replay = self.ledger.append(message(event_id="event-b", body="same body"))
|
||||
|
||||
def test_explicit_quoted_body_never_falls_back_to_storage(ledger: MessageLedger) -> None:
|
||||
assert ledger.resolve_quote(message(quoted_body="exact transport quote")) == "exact transport quote"
|
||||
assert ledger.count() == 0
|
||||
self.assertEqual(stored, replay)
|
||||
self.assertEqual("event-a", replay.event_id)
|
||||
self.assertEqual(1, self.ledger.count())
|
||||
|
||||
@pytest.mark.parametrize("scope_change", [{"tenant_id": "tenant-b"}, {"cell_id": "cell-b"}])
|
||||
def test_quote_lookup_is_tenant_and_cell_isolated(
|
||||
ledger: MessageLedger, scope_change: dict[str, str]
|
||||
) -> None:
|
||||
ledger.append(message())
|
||||
with pytest.raises(ScopeError, match="quoted_text_unavailable"):
|
||||
ledger.resolve_quote(message(**scope_change, event_id="reply-event",
|
||||
message_id="reply-message",
|
||||
reply_to_message_id="message-a"))
|
||||
def test_append_keeps_tenants_isolated(self) -> None:
|
||||
self.ledger.append(message())
|
||||
self.ledger.append(message(tenant_id="tenant-b", cell_id="cell-b"))
|
||||
self.assertEqual(2, self.ledger.count())
|
||||
self.assertEqual("hello", self.ledger.resolve_quote(
|
||||
message(tenant_id="tenant-b", cell_id="cell-b", event_id="event-c",
|
||||
message_id="message-c", body="reply", reply_to_message_id="message-a")
|
||||
))
|
||||
|
||||
def test_same_id_across_directions_is_ambiguous_not_guessed(ledger: MessageLedger) -> None:
|
||||
ledger.append(message(direction="inbound", body="in"))
|
||||
ledger.append(message(direction="outbound", event_id="event-b", body="out"))
|
||||
with pytest.raises(ConflictError, match="ambiguous"):
|
||||
ledger.resolve_quote(message(event_id="event-c", message_id="message-c",
|
||||
reply_to_message_id="message-a"))
|
||||
def test_concurrent_identical_append_is_one_record(self) -> None:
|
||||
with ThreadPoolExecutor(max_workers=16) as executor:
|
||||
records = list(executor.map(lambda _: self.ledger.append(message()), range(16)))
|
||||
self.assertEqual(1, self.ledger.count())
|
||||
self.assertEqual({"message-a"}, {record.message_id for record in records})
|
||||
|
||||
def test_expired_record_is_not_resolved(ledger: MessageLedger) -> None:
|
||||
ledger.append(message())
|
||||
with sqlite3.connect(ledger.database) as db:
|
||||
db.execute("UPDATE message_ledger SET expires_at='2000-01-01T00:00:00+00:00'")
|
||||
with pytest.raises(ScopeError, match="quoted_text_unavailable"):
|
||||
ledger.resolve_quote(message(event_id="event-b", message_id="message-b",
|
||||
reply_to_message_id="message-a"))
|
||||
|
||||
def test_purge_removes_only_expired_records(ledger: MessageLedger) -> None:
|
||||
ledger.append(message())
|
||||
ledger.append(message(event_id="event-b", message_id="message-b"))
|
||||
with sqlite3.connect(ledger.database) as db:
|
||||
db.execute("UPDATE message_ledger SET expires_at='2000-01-01T00:00:00+00:00' "
|
||||
"WHERE message_id='message-a'")
|
||||
assert ledger.purge_expired() == 1
|
||||
assert ledger.count() == 1
|
||||
|
||||
def test_restart_preserves_exact_resolution(tmp_path: Path) -> None:
|
||||
database = tmp_path / "ledger.sqlite3"
|
||||
MessageLedger(database).append(message())
|
||||
reopened = MessageLedger(database)
|
||||
assert reopened.resolve_quote(message(event_id="event-b", message_id="message-b",
|
||||
reply_to_message_id="message-a")) == "hello"
|
||||
|
||||
def test_concurrent_identical_append_is_one_record(ledger: MessageLedger) -> None:
|
||||
with ThreadPoolExecutor(max_workers=16) as executor:
|
||||
records = list(executor.map(lambda _: ledger.append(message()), range(16)))
|
||||
assert ledger.count() == 1
|
||||
assert {record.message_id for record in records} == {"message-a"}
|
||||
|
||||
def test_concurrent_distinct_appends_are_not_lost(ledger: MessageLedger) -> None:
|
||||
def append(index: int) -> None:
|
||||
ledger.append(message(event_id=f"event-{index}", message_id=f"message-{index}"))
|
||||
with ThreadPoolExecutor(max_workers=16) as executor:
|
||||
list(executor.map(append, range(16)))
|
||||
assert ledger.count() == 16
|
||||
|
||||
def test_sqlite_failures_are_sanitized(ledger: MessageLedger) -> None:
|
||||
ledger.database.write_bytes(b"not-a-sqlite-database")
|
||||
with pytest.raises(ConflictError, match="ledger storage unavailable") as raised:
|
||||
ledger.count()
|
||||
assert not isinstance(raised.value, sqlite3.Error)
|
||||
assert "sqlite" not in str(raised.value).lower()
|
||||
assert raised.value.__cause__ is None
|
||||
assert raised.value.__context__ is None
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
|
||||
@@ -1,80 +0,0 @@
|
||||
"""Executable completeness contract for scoped secret references."""
|
||||
from __future__ import annotations
|
||||
from dataclasses import fields
|
||||
import pytest
|
||||
from aios_v2r1.secret_scope import SecretRef
|
||||
from aios_v2r1.tenant_context import ScopeError, ValidationError
|
||||
|
||||
def secret(**changes: object) -> SecretRef:
|
||||
values: dict[str, object] = {
|
||||
"secret_id": "channel-key", "tenant_id": "tenant-a", "cell_id": "cell-a",
|
||||
"kind": "channel", "version": "v1",
|
||||
"broker_path": "secret://tenant-a/cell-a/channel-key/v1"}
|
||||
values.update(changes)
|
||||
return SecretRef(**values) # type: ignore[arg-type]
|
||||
|
||||
@pytest.mark.parametrize("path", [
|
||||
"secret://tenant-a/cell-a/channel-key/v1",
|
||||
"secret://models/provider/key-v2",
|
||||
"secret://runtime/cell-a/signing_key"])
|
||||
def test_valid_broker_paths_are_references(path: str) -> None:
|
||||
assert secret(broker_path=path).broker_path == path
|
||||
|
||||
@pytest.mark.parametrize("path", [
|
||||
"", "vault://tenant-a/key", "secret://", "secret:///key",
|
||||
"secret://tenant-a/../tenant-b/key", "secret://tenant-a//key",
|
||||
"secret://tenant-a/key?version=1", "secret://tenant-a/key#fragment"])
|
||||
def test_broker_path_traversal_and_malformed_paths_are_rejected(path: str) -> None:
|
||||
with pytest.raises(ValidationError, match="broker path"):
|
||||
secret(broker_path=path)
|
||||
|
||||
@pytest.mark.parametrize(("tenant_id", "cell_id", "allowed"), [
|
||||
("tenant-a", "cell-a", True), ("tenant-b", "cell-a", False),
|
||||
("tenant-a", "cell-b", False)])
|
||||
def test_secret_scope_is_exact(tenant_id: str, cell_id: str, allowed: bool) -> None:
|
||||
assert secret().can_be_used_by(tenant_id=tenant_id, cell_id=cell_id) is allowed
|
||||
|
||||
@pytest.mark.parametrize("kind", ["channel", "model", "tool", "runtime"])
|
||||
def test_secret_kind_allowlist(kind: str) -> None:
|
||||
assert secret(kind=kind).kind == kind
|
||||
|
||||
def test_invalid_secret_kind_is_rejected() -> None:
|
||||
with pytest.raises(ValidationError, match="kind"):
|
||||
secret(kind="admin")
|
||||
|
||||
@pytest.mark.parametrize("changes", [
|
||||
{"secret_id": "../key"}, {"secret_id": " key "},
|
||||
{"version": "../v2"}, {"version": ""}, {"tenant_id": "Tenant-A"},
|
||||
{"cell_id": "cell/a"}])
|
||||
def test_secret_identifiers_and_version_are_validated(changes: dict[str, str]) -> None:
|
||||
with pytest.raises(ValidationError):
|
||||
secret(**changes)
|
||||
|
||||
def test_reference_never_contains_a_secret_value_field() -> None:
|
||||
assert "value" not in {field.name for field in fields(SecretRef)}
|
||||
assert "super-secret-value" not in repr(secret())
|
||||
|
||||
def test_broker_resolution_uses_only_the_validated_reference() -> None:
|
||||
seen: list[SecretRef] = []
|
||||
class Broker:
|
||||
def read_secret(self, reference: SecretRef) -> str:
|
||||
seen.append(reference)
|
||||
return "resolved-value"
|
||||
reference = secret()
|
||||
assert reference.resolve(Broker()) == "resolved-value"
|
||||
assert seen == [reference]
|
||||
|
||||
@pytest.mark.parametrize("broker", [None, object()])
|
||||
def test_missing_or_invalid_broker_fails_closed(broker: object | None) -> None:
|
||||
with pytest.raises(ScopeError, match="secret broker unavailable"):
|
||||
secret().resolve(broker)
|
||||
|
||||
def test_broker_error_is_sanitized_without_secret_leakage() -> None:
|
||||
class BrokenBroker:
|
||||
def read_secret(self, reference: SecretRef) -> str:
|
||||
raise RuntimeError("provider leaked super-secret-value")
|
||||
with pytest.raises(ScopeError, match="secret broker unavailable") as raised:
|
||||
secret().resolve(BrokenBroker())
|
||||
assert "super-secret-value" not in str(raised.value)
|
||||
assert raised.value.__cause__ is None
|
||||
assert raised.value.__context__ is None
|
||||
Reference in New Issue
Block a user